-
Notifications
You must be signed in to change notification settings - Fork 171
feat(BA-5565): Unify AppProxy config generation with tomlkit in-place modification #10746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yaminyam
wants to merge
15
commits into
main
Choose a base branch
from
feat/BA-5565-unify-appproxy-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
2f0594e
feat(BA-1982): Add traefik frontend mode support in dev installer
Yaminyam d9a313b
feat(BA-5562): Add pyinfra inventory group_data defaults (Step 1)
Yaminyam 8278723
feat(BA-5562): Migrate InventoryBuilder and fix group_data types (Ste…
Yaminyam 0356ca4
feat(BA-5562): Add DevInventoryBuilder for local pyinfra deployment (…
Yaminyam 5eea5e8
feat(BA-5562): Add pyinfra local inventory entry point (Step 4)
Yaminyam 04a5270
feat(BA-5562): Extract shared defaults for dev mode reuse (Step 5)
Yaminyam a12cd2c
feat(BA-5562): Add tests and enable mypy for pyinfra module (Step 6)
Yaminyam 70d0159
fix(BA-5562): Fix invalid config field names and add changelog
Yaminyam c6660f1
fix(BA-5563): Add run_local.py workaround for gevent subprocess bug o…
Yaminyam d3f76cc
fix(BA-5562): Add pyinfra/passlib to lock file and fix test type anno…
Yaminyam 2556c33
feat(BA-5565): Unify AppProxy config generation into shared module
Yaminyam 98da20a
refactor(BA-5565): Use tomlkit in-place modification for appproxy config
Yaminyam 57a9210
fix(BA-5565): Fix mypy type errors for tomlkit indexing in CI
Yaminyam 30a490b
fix(BA-5565): Fix remaining CI lint/typecheck errors
Yaminyam aa57290
fix(BA-5565): Remove last unused type: ignore in deploy_operational_s…
Yaminyam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| [db] | ||
| type = "postgresql" | ||
| name = "appproxy" | ||
| user = "appproxy" | ||
| password = "develove" | ||
| pool_size = 8 | ||
| max_overflow = 64 | ||
| addr = { host = "127.0.0.1", port = 8101 } | ||
|
|
||
| [redis] | ||
| addr = { host = "127.0.0.1", port = 8111 } | ||
|
|
||
| [proxy_coordinator] | ||
| tls_listen = false | ||
| tls_advertised = false | ||
| aiomonitor_termui_port = 48510 | ||
| aiomonitor_webui_port = 49510 | ||
| allow_unauthorized_configure_request = true | ||
|
|
||
| [proxy_coordinator.bind_addr] | ||
| host = "0.0.0.0" | ||
| port = 10200 | ||
|
|
||
| [proxy_coordinator.advertised_addr] | ||
| # Change `host` and `port` to the actual host and port for user access | ||
| host = "127.0.0.1" | ||
| port = 10200 | ||
|
|
||
| [secrets] | ||
| api_secret = "WPoPk3_Z11yqeQ673w3KuJzXb1fbSNSmAXTaEgJ7_kM" | ||
| jwt_secret = "ADadDTqhua1hIzIj7WnFWnSe-3mWclNv9brIrH2M-Ik" | ||
|
|
||
| [permit_hash] | ||
| secret = "_ys4SubzC_3FungNVEOPieA_LFXRuyOUgzvJ2eiQFSk" | ||
|
|
||
| [logging] | ||
| level = "DEBUG" | ||
| drivers = ["console"] | ||
|
|
||
| [logging.console] | ||
| colored = true | ||
| format = "verbose" | ||
|
|
||
| [debug] | ||
| enabled = true | ||
| log-events = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| [redis] | ||
| addr = { host = "127.0.0.1", port = 8111 } | ||
|
|
||
| [proxy_worker] | ||
| coordinator_endpoint = "http://127.0.0.1:10200" | ||
| authority = "worker-1" | ||
| tls_listen = false | ||
| tls_advertised = false | ||
| aiomonitor_termui_port = 48610 | ||
| aiomonitor_webui_port = 49610 | ||
| frontend_mode = "port" | ||
| protocol = "http" | ||
| accepted_traffics = ["inference", "interactive"] | ||
| api_bind_addr = { host = "0.0.0.0", port = 10201 } | ||
| # Change `host` to the public/external address for user access. Change `port` only if port mapping is in use. | ||
| api_advertised_addr = { host = "127.0.0.1", port = 10201 } | ||
|
|
||
| [proxy_worker.port_proxy] | ||
| bind_host = "0.0.0.0" | ||
| # Change to the actual host for user access | ||
| advertised_host = "127.0.0.1" | ||
| bind_port_range = [10205, 10300] | ||
|
|
||
| [secrets] | ||
| api_secret = "WPoPk3_Z11yqeQ673w3KuJzXb1fbSNSmAXTaEgJ7_kM" | ||
| jwt_secret = "ADadDTqhua1hIzIj7WnFWnSe-3mWclNv9brIrH2M-Ik" | ||
|
|
||
| [permit_hash] | ||
| secret = "_ys4SubzC_3FungNVEOPieA_LFXRuyOUgzvJ2eiQFSk" | ||
|
|
||
| [logging] | ||
| level = "DEBUG" | ||
| drivers = ["console"] | ||
|
|
||
| [logging.console] | ||
| colored = true | ||
| format = "verbose" | ||
|
|
||
| [debug] | ||
| enabled = true | ||
| log-events = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Migrate pyinfra inventory system from backend.ai-installer with dev inventory support | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry filename
changes/10738.feature.mdappears to reference a different PR/issue number than this PR (BA-5565). If your project expects one changeset file per PR, this will misattribute release notes. Consider renaming the changes file to match the current PR number / convention used in the repo.