feat(BA-5765): add RBAC-enforced VFolder purge mutation#11165
Merged
Conversation
github-actions
Bot
added
size:L
fregataa
force-pushed
the
feature/BA-5765-vfolder-purge-rbac
branch
from
5812862 to
66164d9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an RBAC-enforced purge path for the v2 VFolder REST mutation, shifting authorization to the SingleEntityActionProcessor/RBAC validators and introducing a dedicated service method for the RBAC flow.
Changes:
- Introduce
PurgeVFolderV2RBACAction(+ result) and wire it intoVFolderProcessorsviaSingleEntityActionProcessor. - Add
VFolderService.purge_v2_rbac()and route the v2 adapterpurge()call through the RBAC processor. - Add a component test covering the “regular user denied” scenario and a towncrier fragment.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/component/vfolder_v2/test_vfolder_mutation.py | New component test exercising the v2 purge endpoint via SDK (currently denial-only). |
| src/ai/backend/manager/services/vfolder/services/vfolder.py | Adds purge_v2_rbac() service implementation used by the RBAC processor. |
| src/ai/backend/manager/services/vfolder/processors/vfolder.py | Registers the new RBAC purge action + processor and advertises it in supported_actions(). |
| src/ai/backend/manager/services/vfolder/actions/vfolder_in_project.py | New RBAC purge action/result definitions for single-entity validation. |
| src/ai/backend/manager/api/adapters/vfolder.py | Routes purge() to the new RBAC processor (bulk purge remains legacy). |
| changes/BA-5765.feature.md | Towncrier fragment documenting the new RBAC-enforced purge mutation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fregataa
force-pushed
the
feature/BA-5765-vfolder-purge-rbac
branch
from
66164d9 to
219f0ac
Compare
Member
|
Is there a reason why |
fregataa
force-pushed
the
feature/BA-5765-vfolder-purge-rbac
branch
from
219f0ac to
6046cdf
Compare
Member
Author
Because batch RBAC validation is not ready yet. I target this job to support purge single VFolder only and I will impl batch purge with RBAC in the future. Check #11186 @jopemachine |
fregataa
force-pushed
the
feature/BA-5765-vfolder-purge-rbac
branch
2 times, most recently
from
481310c to
2fa6802
Compare
Member
|
Please resolve the conflict |
Add PurgeVFolderV2RBACAction (SingleEntityActionProcessor + RBAC). Adapter purge() routes to RBAC path; bulk_purge() stays on legacy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rV2Action Merge PurgeVFolderV2RBACAction into PurgeVFolderV2Action by switching its base to VFolderSingleEntityAction and removing user_id field. The service method now uses current_user() for host permission checks instead of receiving user_id through the action. Drop the redundant purge_v2_rbac service/processor path and vfolder_v2_rbac.py module. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…is missing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fregataa
force-pushed
the
feature/BA-5765-vfolder-purge-rbac
branch
from
2fa6802 to
0e00ab1
Compare
jopemachine
approved these changes
Apr 22, 2026
jopemachine
pushed a commit
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PurgeVFolderV2RBACAction(SingleEntityActionProcessor+single_entity_rbac_validators).purge_v2_rbac()—get_by_id+delete_vfolders_forever+ storage removal, no manual user/host checks.purge()routes to RBAC processor;bulk_purge()stays on legacy path.Test plan
pants fmt/fix/lint/check— greenTestPurgeVFolderRBAC(regular user 403) via SDKResolves BA-5765