Skip to content

fix(agent): Scope aiodocker client in DockerKernel.commit() via closing_async #11228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rapsealk wants to merge 1 commit into from
Closed

fix(agent): Scope aiodocker client in DockerKernel.commit() via closing_async #11228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/11228.fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a leaked aiodocker session in `DockerKernel.commit()` by scoping the client via `closing_async`.
5 changes: 1 addition & 4 deletions src/ai/backend/agent/docker/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ def _write_chunks(
try:
async with FileLock(path=lock_path, timeout=0.1, remove_when_unlock=True):
log.info("Container (k: {}) is being committed", kernel_id)
docker = Docker()
try:
async with closing_async(Docker()) as docker:
# There is a known issue at certain versions of Docker Engine
# which prevents container from being committed when request config body is empty
# https://github.com/moby/moby/issues/45543
Expand Down Expand Up @@ -289,8 +288,6 @@ def _write_chunks(
await write_task
finally:
await docker.images.delete(image_id)
finally:
await docker.close()
except TimeoutError:
log.warning("Session is already being committed.")

Expand Down
Loading