test(BA-5824): add unit tests for FixedQueryBuilder#11273
Merged
Conversation
seedspirit
force-pushed
the
test/BA-5824
branch
from
bb90878 to
7c49365
Compare
seedspirit
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds unit tests around the Prometheus query-building utilities in ai.backend.common.clients.prometheus, focusing on verifying metric type classification, query preset construction, and live-stat query label filtering.
Changes:
- Add a new unit test module covering
FixedQueryBuilderbehavior (metric type classification, query rendering, live-stat presets, and_regex_unionescaping). - Add a Towncrier news fragment documenting the test addition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/unit/common/clients/prometheus/test_fixed_query_builder.py |
New unit tests for FixedQueryBuilder query construction and helper behavior. |
changes/11273.test.md |
Towncrier fragment noting the addition of unit tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fregataa
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FixedQueryBuilder(query building logic, metric type classification, live stat query construction,_regex_unionhelper)Test plan
🤖 Generated with Claude Code