fix: Unable to login and missing keypairs when a user does not have any project #1360
+17
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
kyujin-cho
requested changes
Jul 3, 2023
Comment on lines
328
to
334
| sa.join(keypairs, users, keypairs.c.user == users.c.uuid, isouter=True) | ||
| .join( | ||
| association_groups_users, | ||
| users.c.uuid == association_groups_users.c.user_id, | ||
| isouter=True, | ||
| ) | ||
| .join(groups, association_groups_users.c.group_id == groups.c.id, isouter=True) |
There was a problem hiding this comment.
We should never OUTER JOIN three tables in any case.
achimnol
changed the title
Keypair graphene query mismatch between count and sliceKeyPair GraphQL query mismatch between count and slice
achimnol
added a commit
that referenced
this pull request
Oct 24, 2023
achimnol
requested changes
Oct 24, 2023
|
Another issue to look together: if there exists a user who does not belong to any project, all user's login is blocked due to a query error. |
achimnol
changed the title
KeyPair GraphQL query mismatch between count and slice
achimnol
added
urgency:blocker
|
This should be resoled before shipping 23.09.5. |
9 tasks
…and-slice' into fix/keypair-query-correct-count-and-slice
|
@achimnol I resolved the issue that unable to fetch keypairs whose user is not associate with any project. 
|
fregataa
added
urgency:4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #1022
If a user is not associated with any group (project), the user's keypairs are not included in the
KeyPairListquery result, with a mismatch ofcountandsliceresolvers.If one or more user is not associated with any group (project), all users cannot login to the web UI. At least, the login error should be confined to the specific user, without affecting other users with proper project memberships.
Suggestion
How about deprecating
projectsfields of Keypairs?I made a commit to test it
Checklist: (if applicable)