feat(BA-7268): add docker-images workflow to build and push service images via OIDC - #13700
Open
kyujin-cho wants to merge 4 commits into
Open
feat(BA-7268): add docker-images workflow to build and push service images via OIDC#13700kyujin-cho wants to merge 4 commits into
kyujin-cho wants to merge 4 commits into
Conversation
13595.feature.md -> 13700.feature.md Co-authored-by: octodog <mu001@lablup.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds reusable multi-architecture Docker image publishing with Docker Hub OIDC authentication.
Changes:
- Builds and pushes discovered service images for AMD64 and ARM64.
- Adds release-version normalization and image tagging.
- Reduces Docker build context and documents the workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/docker-images.yml |
Defines image build and publishing workflow. |
.dockerignore |
Excludes unnecessary source directories. |
scripts/normalize-version.py |
Normalizes versions for Docker tags. |
scripts/README.md |
Documents workflow helper scripts. |
changes/13595.feature.md |
Adds the feature changelog entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+100
to
+101
| - name: Assert the tag matches the VERSION file | ||
| if: github.ref_type == 'tag' |
Comment on lines
+154
to
+155
| run-id: ${{ inputs.wheels-run-id || github.run_id }} | ||
| github-token: ${{ github.token }} |
Comment on lines
+163
to
+166
| - name: Login to Docker Hub via OIDC | ||
| uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0 | ||
| env: | ||
| DOCKERHUB_OIDC_CONNECTIONID: ${{ vars.DOCKERHUB_OIDC_CONNECTION_ID }} |
Comment on lines
+178
to
+179
| type=raw,value=${{ needs.prepare.outputs.pkgver }} | ||
| type=raw,value=latest,enable=${{ needs.prepare.outputs.is-prerelease == 'false' }} |
Comment on lines
+12
to
+31
| import sys | ||
|
|
||
| from packaging.version import InvalidVersion, Version | ||
|
|
||
|
|
||
| def main() -> None: | ||
| raw = sys.argv[1].strip() | ||
| try: | ||
| version = Version(raw) | ||
| except InvalidVersion: | ||
| print(f"error: {raw!r} is not a valid PEP 440 version", file=sys.stderr) | ||
| sys.exit(1) | ||
| if version.local is not None: | ||
| print( | ||
| f"error: {raw!r} has a local version segment" | ||
| " ('+' is not a legal character in a docker tag)", | ||
| file=sys.stderr, | ||
| ) | ||
| sys.exit(1) | ||
| print(version) |
fregataa
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #13595.
Resolves BA-7268
Resolves #13586