feat(BA-7321): add DOCKER install mode deploying the published service images - #13703
Open
kyujin-cho wants to merge 5 commits into
Open
feat(BA-7321): add DOCKER install mode deploying the published service images#13703kyujin-cho wants to merge 5 commits into
kyujin-cho wants to merge 5 commits into
Conversation
…exec safety, project isolation)
kyujin-cho
force-pushed
the
feat/BA-7321/docker-install-mode-v2
branch
from
August 11, 2026 13:47
4b5a750 to
01679e7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Docker Compose installer mode for deploying and bootstrapping published Backend.AI service images.
Changes:
- Adds DOCKER mode plumbing, setup UI, and installation report.
- Generates and manages containerized services with path-parity mounts.
- Adds compose-template rendering tests.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/ai/backend/install/types.py |
Adds Docker install enums. |
src/ai/backend/install/context.py |
Implements Docker deployment and bootstrap orchestration. |
src/ai/backend/install/configs/docker-compose.services.yml |
Defines service containers and mounts. |
src/ai/backend/install/app.py |
Adds Docker setup UI and report. |
tests/unit/install/test_docker_services_compose.py |
Tests compose rendering and service configuration. |
tests/unit/install/BUILD |
Registers installer unit tests. |
tests/unit/install/__init__.py |
Marks the test package. |
changes/13681.feature.md |
Documents the new install mode. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2357
to
+2361
| if self.install_variable.accelerator is not None: | ||
| raise PrerequisiteError( | ||
| "The published lablup/backend.ai-* service images do not yet " | ||
| "bundle the accelerator plugins, so --accelerator would produce " | ||
| "a broken DOCKER-mode deployment.", |
| # configure | ||
| await ctx.configure() | ||
| # post-setup | ||
| await ctx.populate_images() |
Comment on lines
+2569
to
+2581
| # Post-start health verification: warn (but do not fail the install) | ||
| # when some services are not in the running state. | ||
| non_running = await self._collect_non_running_services() | ||
| if non_running: | ||
| self.log.write( | ||
| Text.from_markup( | ||
| "[yellow bold]:warning: Some service containers are not " | ||
| f"running: {', '.join(sorted(non_running))}.[/]\n" | ||
| "[yellow]Inspect them with " | ||
| f"[bold]docker compose -f {self.SERVICES_COMPOSE_FILENAME} " | ||
| "ps / logs <service>[/] before using the deployment.[/]" | ||
| ) | ||
| ) |
Comment on lines
+2594
to
+2596
| "ps", | ||
| "--format", | ||
| "json", |
Comment on lines
+29
to
+35
| privileged: true | ||
| working_dir: {{BASE_PATH}} | ||
| command: ["python", "-m", "ai.backend.manager.server", "--config", "{{BASE_PATH}}/manager.toml"] | ||
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock | ||
| - /etc/machine-id:/etc/machine-id:ro | ||
| - {{BASE_PATH}}:{{BASE_PATH}} |
fregataa
previously approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #13681.
Resolves BA-7321
Resolves #13680