-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Standalone watcher #1560
Draft
fregataa
wants to merge
69
commits into
main
Choose a base branch
from
feature/standalone-storage-watcher
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,486
−320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er' into feature/standalone-storage-watcher
1 task
Since control panel would be the one that requests to watcher servers, I made an issue about supporting HTTPS in control panel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action:on hold
Hold it. Wait for the restart.
comp:manager
Related to Manager component
comp:storage-proxy
Related to Storage proxy component
comp:webserver
Related to Web Server component
size:XL
500~ LoC
urgency:3
Must be finished within a certain time frame.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ai.backend.watcher
-f/--config
option while searchingwatcher.toml
Follow-ups
The PRs below should be merged after this get merged
https://github.com/lablup/backend.ai-storage-watcher/pull/1https://github.com/lablup/backend.ai-agent-watcher/pull/1How to test
You can find a sample config toml file in each watcher repository.
storage watcher: https://github.com/lablup/backend.ai-storage-watcher
agent watcher: https://github.com/lablup/backend.ai-agent-watcher
If you want to run multiple watcher plugins in one watcher process, install the all watcher plugins and set all configs in one file and pass the path of the config file.
TODO
Checklist: (if applicable)