chore: enable raise-without-from-inside-except ruff rule #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyujin-cho
added
skip:changelog
github-actions
bot
added
comp:client
achimnol
reviewed
Dec 3, 2023
| @@ -143,7 +143,7 @@ async def route_structure_fallback_middleware( | |||
| structure_pointer = self.route_structure | |||
| for component in components: | |||
| if structure_pointer.get(component) is None: | |||
| raise web.HTTPNotFound | |||
| raise web.HTTPNotFound from None | |||
There was a problem hiding this comment.
In this case, I think we should simply reraise the original exception.
Suggested change
| raise web.HTTPNotFound from None | |
| raise |
achimnol
requested changes
Dec 3, 2023
There was a problem hiding this comment.
For the auto-generated as ex expressions, I think it would be better to unify the style: as e.
According to the official doc, Python automatically attach the chaining information when the raise statement is inside an except block.
We should force this rule only when the raise statement is not inside the except block.
| @@ -350,9 +350,9 @@ async def _download_file( | |||
| chunk_size | |||
| ) | |||
| except asyncio.TimeoutError: | |||
| raise TryAgain | |||
There was a problem hiding this comment.
Couldn't we just simply raise a "root" exception instead of specifying from None always for brevity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help investigating root cause of the error more easier when inspecting the error log.
Checklist: (if applicable)