Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add association table between ContainerRegistries with Users #1960

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Mar 16, 2024

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes

Will fix #1908, #1910

Changes

  • Add association table between ContainerRegistries with Users
  • Add graphql APIs for the association table
  • Extend image graphql API to support querying available images available from user's own container registry

@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated labels Mar 16, 2024
@github-actions github-actions bot added the size:L 100~500 LoC label Mar 16, 2024
@jopemachine jopemachine linked an issue Mar 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added this to the 24.03 milestone Mar 16, 2024
@jopemachine jopemachine changed the title feat: Add association ContainerRegistries with Users table feat: Add association table between ContainerRegistries with Users Mar 16, 2024
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch from 5a04200 to b86efe8 Compare March 17, 2024 13:01
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Mar 17, 2024
@jopemachine jopemachine force-pushed the feat/add-association-container-registries-users-table branch 2 times, most recently from f79f8b0 to 7505e1e Compare March 17, 2024 22:01
@github-actions github-actions bot added the comp:client Related to Client component label Mar 22, 2024
@jopemachine jopemachine force-pushed the feat/add-association-container-registries-users-table branch 2 times, most recently from 96fd0d5 to c57e880 Compare March 22, 2024 03:36
@jopemachine jopemachine modified the milestones: 24.03, 24.09 Apr 24, 2024
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch 2 times, most recently from 0529d8f to a27f32f Compare August 3, 2024 02:11
@fregataa fregataa force-pushed the feat/migration-container-registries branch from 956f205 to 0fe95df Compare August 4, 2024 02:05
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch 4 times, most recently from 9732dfa to 443a62f Compare August 8, 2024 06:56
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch 2 times, most recently from 97f826c to 78477bc Compare August 21, 2024 07:35
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch 3 times, most recently from a2349c0 to 9f44f5c Compare September 9, 2024 01:28
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch from 9f44f5c to ba83a7a Compare September 18, 2024 06:23
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch from d0fa33a to bfd11a3 Compare September 19, 2024 07:56
@jopemachine jopemachine force-pushed the feat/migration-container-registries branch from bfd11a3 to 412b9a1 Compare September 30, 2024 12:20
Base automatically changed from feat/migration-container-registries to main September 30, 2024 14:21
@jopemachine
Copy link
Member Author

jopemachine commented Oct 21, 2024

This PR has not been updated for a long time and includes changes from the old container registry migration PR. I will update it soon.

-> Merge with the main branch completed.

@jopemachine
Copy link
Member Author

According to the priority, I will first create the m2m table between the ContainerRegistries and Group (project) tables in another PR.

@jopemachine jopemachine force-pushed the feat/add-association-container-registries-users-table branch from e77a2e7 to efdb340 Compare November 5, 2024 01:36
@jopemachine jopemachine modified the milestones: 24.09, 24.12 Nov 5, 2024
@jopemachine
Copy link
Member Author

According to the priority, I will first create the m2m table between the ContainerRegistries and Group (project) tables in another PR.

If we can replace m2m table itself with RBAC, we will skip this PR.

@jopemachine
Copy link
Member Author

According to the priority, I will first create the m2m table between the ContainerRegistries and Group (project) tables in another PR.

If we can replace m2m table itself with RBAC, we will skip this PR.

After reviewing, we concluded that even with RBAC applied, we should still create an m2m table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action:on hold Hold it. Wait for the restart. comp:client Related to Client component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per-project container registry mapping (or RBAC)
1 participant