feature: apply enhanced postgres cnx mgmt to registry and scheduler modules #2103
+1,241
−1,067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This was referenced May 3, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
fregataa
force-pushed
the
topic/feature/improve-psql-cnx-mgmt
branch
from
0cf662b to
a9af7e1
Compare
fregataa
force-pushed
the
topic/05-03-feature_apply_enhanced_postgres_cnx_mgmt_to_registry_and_scheduler_modules
branch
from
e78789e to
b4b91d6
Compare
fregataa
force-pushed
the
topic/feature/improve-psql-cnx-mgmt
branch
from
a9af7e1 to
77538a3
Compare
fregataa
force-pushed
the
topic/05-03-feature_apply_enhanced_postgres_cnx_mgmt_to_registry_and_scheduler_modules
branch
from
b4b91d6 to
3a04459
Compare
fregataa
force-pushed
the
topic/feature/improve-psql-cnx-mgmt
branch
from
77538a3 to
f38b0e5
Compare
fregataa
force-pushed
the
topic/05-03-feature_apply_enhanced_postgres_cnx_mgmt_to_registry_and_scheduler_modules
branch
from
3a04459 to
c32d461
Compare
fregataa
force-pushed
the
topic/feature/improve-psql-cnx-mgmt
branch
from
f38b0e5 to
c81529f
Compare
fregataa
force-pushed
the
topic/05-03-feature_apply_enhanced_postgres_cnx_mgmt_to_registry_and_scheduler_modules
branch
from
c32d461 to
f80e1d4
Compare
achimnol
force-pushed
the
topic/feature/improve-psql-cnx-mgmt
branch
from
2022abc to
5cfd9df
Compare
achimnol
changed the base branch from
topic/feature/improve-psql-cnx-mgmt
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve PostgreSQL connection management.
Replace
execute_with_retrytoexecute_with_txn_retryin registry and scheduler module.Notice
Some of the code that retries DB calls through the
execute_with_retry()API has been modified to prevent further retries because the DB calls will not be retried as intended.get_*_occupancy()APIs do not retry DB calls anymore becauseexecute_with_retry()retries only whenSerializationErroroccurs, which requires retry the entire transaction, not rolling back toCHECKPOINT.Checklist: (if applicable)