-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Split config/halfstack/global contexts from root context #3154
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8ce4dc0
to
46c011a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, even if the root context is divided into substructures, the significance of refactoring diminishes if the root context is still being accessed directly.
It seems necessary to explicitly pass only the required configuration values to handlers or other modules.
Are there any tasks you are considering regarding this? @achimnol
46c011a
to
535e3b7
Compare
Ultimately yes, but this PR is an interim step towards that goal. Each category would have different sharing scopes. For instance:
I think introducing an explicit hierarchy to the root context will help us to automatically replace the references across the entire manager codebase after #3183. |
This PR splits
RootContext
into three categories of contextual objects:pidx
)Relationship:
RootContext
to explicitly distinguish context info groups #3156 (BA-37)Checklist: (if applicable)