feat(BA-624): Add vfolder repository layer in manager #3669
Conversation
github-actions
bot
added
comp:manager
Co-authored-by: octodog <[email protected]>
…ttps://github.com/lablup/backend.ai into feat/implement-vfolder-repository-layer-in-manager
There was a problem hiding this comment.
The repository layer contains too much service logic.
@HyeockJinKim We should discuss the RBAC interface and implement it before proceeding with this work.
| async def get_group_type(self, group_id: uuid.UUID) -> ProjectType: | ||
| async with self._db.begin_session() as sess: | ||
| query = sa.select(GroupRow).where(GroupRow.id == group_id) | ||
| group_row = await sess.scalar(query) | ||
|
|
||
| if group_row is None: | ||
| raise GroupNotFound(extra_data=group_id) | ||
|
|
||
| return group_row.type |
There was a problem hiding this comment.
Why is there a project querying function in the VFolderRepository class?
I understand this function might be needed to check permissions of vfolders related to group types. Please add comments explaining the implementation rationale and provide guidance for future contributors. e.g. Relocate this function to ProjectRepository etc
There was a problem hiding this comment.
I added this to the vFolderRepository because the existing vfolder create API operation used that behavior. For now, how about leave it in this repository for now and move it when another repository is created, perhaps as a TODO comment for future contributor?
| async def get_user_container_id(self, user_id: uuid.UUID) -> Optional[int]: | ||
| async with self._db.begin_session() as sess: | ||
| query = sa.select(UserRow.container_uid).where(UserRow.uuid == user_id) | ||
| result = await sess.scalar(query) | ||
| return result |
There was a problem hiding this comment.
Also same here. I added this method cause it was part of vfolder create API. As this PR is the first PR for introducing repository layer in vfolder API, how about leave it in this repository for now and move it when another repository is created, perhaps as a TODO comment for future contributor?
| async def persist_vfolder_metadata(self, metadata: VFolderMetadataToCreate) -> VFolderItem: | ||
| async with self._db.begin_session() as sess: | ||
| insert_query = sa.insert(VFolderRow).values(metadata.to_dict()).returning(VFolderRow.id) | ||
| vfolder_id = await sess.scalar(insert_query) | ||
|
|
||
| query = sa.select(VFolderRow).where(VFolderRow.id == vfolder_id) | ||
| vfolder: VFolderRow = await sess.scalar(query) | ||
| vfolder_item = VFolderItem.from_orm(orm=vfolder, is_owner=True) | ||
| return vfolder_item |
There was a problem hiding this comment.
- It is good to wrap a DB write execution into
execute_with_txn_retry(). - Just a question, why is the name of this method "persist_...()?
There was a problem hiding this comment.
Since the vfolder needs to complete requests to the storage-proxy, etc. to be fully created, I thought it would be more accurate to say that the vfolder was 'persisted' to the DB in a more strict sense rather than 'added' or 'created'
resolves #3558 (BA-624)
Implemented repository layer for vfolder api in manager. Repository layer use
database_engine (ExtendedAsyncSAEngine)created in/manager/models/utilsChecklist: (if applicable)
ai.backend.testdocsdirectory📚 Documentation preview 📚: https://sorna--3669.org.readthedocs.build/en/3669/
📚 Documentation preview 📚: https://sorna-ko--3669.org.readthedocs.build/ko/3669/