Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(BA-696): Change Absolute Imports to Relative Imports in Storage-Proxy (#3656) #3685

Open
wants to merge 1 commit into
base: refactor/storage-service
Choose a base branch
from

Conversation

MintCat98
Copy link
Contributor

@MintCat98 MintCat98 commented Feb 13, 2025

resolves #3656 (BA-696)

To follow the import convention:

  • Use relative imports when importing modules within the same package.
  • Use absolute imports when importing modules from a different package.

Files are changed:

  • common/dto/storage/*.py
  • storage/api/vfolder/handler.py
  • storage/services/service.py
  • storage/volumes/*.py (includes cephfs, ddn, etc.)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added comp:common Related to Common component comp:storage-proxy Related to Storage proxy component size:XL 500~ LoC labels Feb 13, 2025
@MintCat98 MintCat98 changed the base branch from main to refactor/storage-service February 13, 2025 04:44
@MintCat98 MintCat98 force-pushed the refactor/rel-path-convention branch from 821e005 to e1f8f04 Compare February 13, 2025 04:46
@github-actions github-actions bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Feb 13, 2025
@MintCat98 MintCat98 force-pushed the refactor/rel-path-convention branch from e1f8f04 to 117e3b9 Compare February 13, 2025 05:42
@github-actions github-actions bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:common Related to Common component comp:storage-proxy Related to Storage proxy component size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Absolute Imports to Relative Imports in Storage-Proxy
1 participant