-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BA-24): Split redis config for each connection pool #3725
base: main
Are you sure you want to change the base?
feat(BA-24): Split redis config for each connection pool #3725
Conversation
STANDARD_FIELDS = frozenset({ | ||
"addr", | ||
"sentinel", | ||
"service_name", | ||
"password", | ||
"redis_helper_config", | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this setting necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As redis config allows extra fields, we need to add what is standard and what is not standard fields.
The only way I know of to add a field that is not predefined in the dataclass is to have it as a set or dict, as it is currently. Is there any other way?
redis_config_iv = t.Dict({
t.Key("addr", default=redis_default_config["addr"]): t.Null | tx.HostPortPair,
...
t.Key("override_configs", default=None): t.Null
| t.Mapping(
t.String,
t.Dict({
t.Key("addr", default=redis_default_config["addr"]): t.Null | tx.HostPortPair,
...
}).allow_extra("*"),
),
}).allow_extra("*")
STAT = "stat" | ||
RLIM = "rlim" | ||
LIVE = "live" | ||
IMAGE = "image" | ||
STREAM = "stream" | ||
STREAM_LOCK = "stream_lock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using abbreviations like RLIM
.
resolves #3195 (BA-24)
Checklist: (if applicable)
ai.backend.test
docs
directory