fix: Wrong required reservoir_config error#6361
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the manager incorrectly raises a ServerMisconfiguredError when reservoir_config is not configured, even though it should be optional. The fix removes the unnecessary error check and instead safely handles the optional configuration by only starting the reservoir registry scan task when the configuration is present and delegation is enabled.
- Removed incorrect mandatory check for
reservoir_config - Added safe optional handling for the reservoir registry scan task
- Removed unused
ServerMisconfiguredErrorimport
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
github-actions
Bot
added
size:XS
jopemachine
added
the
skip:changelog
HyeockJinKim
approved these changes
Oct 23, 2025
lablup-octodog
pushed a commit
that referenced
this pull request
Oct 23, 2025
Backported-from: main (25.16) Backported-to: 25.15 Backport-of: 6361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of #6330.
Checklist: (if applicable)