fix: Agent summary query build order#6389
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the order of query building operations in the agent summary query to ensure filters and ordering are applied before adding join clauses. The change moves the filter, order, and status conditions to execute before the select_from clause construction.
Key Changes:
- Reordered query construction to apply WHERE clauses and ORDER BY clauses before JOIN operations
- Moved filter/order/status logic from after
_append_sgroup_from_clauseto beforeselect_from
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
HyeockJinKim
approved these changes
Oct 24, 2025
78b8b94 to
68550c0
Compare
lablup-octodog
pushed a commit
that referenced
this pull request
Oct 24, 2025
Backported-from: main (25.16) Backported-to: 25.15 Backport-of: 6389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #NNN (BA-MMM)
Checklist: (if applicable)
ai.backend.testdocsdirectory