Skip to content

fix: Agent summary query build order#6389

Merged
HyeockJinKim merged 2 commits into
mainfrom
fix/agent-summary-query-build-order
Oct 24, 2025
Merged

fix: Agent summary query build order#6389
HyeockJinKim merged 2 commits into
mainfrom
fix/agent-summary-query-build-order

Conversation

@fregataa
Copy link
Copy Markdown
Member

resolves #NNN (BA-MMM)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@fregataa fregataa added this to the 25.15 milestone Oct 24, 2025
@fregataa fregataa self-assigned this Oct 24, 2025
Copilot AI review requested due to automatic review settings October 24, 2025 05:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the order of query building operations in the agent summary query to ensure filters and ordering are applied before adding join clauses. The change moves the filter, order, and status conditions to execute before the select_from clause construction.

Key Changes:

  • Reordered query construction to apply WHERE clauses and ORDER BY clauses before JOIN operations
  • Moved filter/order/status logic from after _append_sgroup_from_clause to before select_from

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions Bot added size:M 30~100 LoC comp:manager Related to Manager component labels Oct 24, 2025
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Oct 24, 2025
@HyeockJinKim HyeockJinKim removed this pull request from the merge queue due to a manual request Oct 24, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Oct 24, 2025
@fregataa fregataa force-pushed the fix/agent-summary-query-build-order branch from 78b8b94 to 68550c0 Compare October 24, 2025 09:09
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit da52b58 Oct 24, 2025
29 of 30 checks passed
@HyeockJinKim HyeockJinKim deleted the fix/agent-summary-query-build-order branch October 24, 2025 09:24
lablup-octodog pushed a commit that referenced this pull request Oct 24, 2025
Backported-from: main (25.16)
Backported-to: 25.15
Backport-of: 6389
github-merge-queue Bot pushed a commit that referenced this pull request Oct 24, 2025
Co-authored-by: Sanghun Lee <sanghun@lablup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants