Skip to content

chore: Revert supergraph.yaml#6402

Merged
HyeockJinKim merged 1 commit into
mainfrom
chore/revert-rover-config
Oct 26, 2025
Merged

chore: Revert supergraph.yaml#6402
HyeockJinKim merged 1 commit into
mainfrom
chore/revert-rover-config

Conversation

@HyeockJinKim
Copy link
Copy Markdown
Collaborator

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

Copilot AI review requested due to automatic review settings October 26, 2025 03:10
@HyeockJinKim HyeockJinKim added the skip:changelog Make the action workflow to skip towncrier check label Oct 26, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the supergraph.yaml configuration file to a previous version and updates the related documentation to provide more detailed explanations about supergraph composition.

  • Restores the original supergraph.yaml file with Apollo Rover configuration for GraphQL Federation
  • Enhances the README documentation with clearer explanations of the Rover composition process
  • Adds inline comments to supergraph.yaml explaining its purpose and usage

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
configs/graphql/supergraph.yaml Reverts to the original version with detailed header comments explaining Rover composition usage
configs/graphql/README.md Expands documentation about supergraph composition, Rover configuration, and the composition workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions Bot added the size:M 30~100 LoC label Oct 26, 2025
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Oct 26, 2025
@@ -0,0 +1,27 @@
# Rover Supergraph Composition Configuration
#
# This file is used by Apollo Rover CLI to compose multiple subgraph schemas

Check warning

Code scanning / devskim

An HTTP-based URL without TLS was detected. Warning

Insecure URL
# into a unified supergraph schema for GraphQL Federation.
#
# Usage:
# rover supergraph compose --config configs/graphql/supergraph.yaml > docs/manager/graphql-reference/supergraph.graphql

Check warning

Code scanning / devskim

An HTTP-based URL without TLS was detected. Warning

Insecure URL
Merged via the queue into main with commit 6a8dda3 Oct 26, 2025
33 checks passed
@HyeockJinKim HyeockJinKim deleted the chore/revert-rover-config branch October 26, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants