Skip to content

feat(BA-2850): Support OCP Container Registry#6464

Merged
HyeockJinKim merged 11 commits into
mainfrom
feat/support_ocr
Nov 27, 2025
Merged

feat(BA-2850): Support OCP Container Registry#6464
HyeockJinKim merged 11 commits into
mainfrom
feat/support_ocr

Conversation

@jopemachine

@jopemachine jopemachine commented Oct 29, 2025

Copy link
Copy Markdown
Member

resolves #6467 (BA-2850)

Checklist: (if applicable)

  • Mention to the original issue

📚 Documentation preview 📚: https://sorna--6464.org.readthedocs.build/en/6464/


📚 Documentation preview 📚: https://sorna-ko--6464.org.readthedocs.build/ko/6464/

@github-actions github-actions Bot added size:L 100~500 LoC comp:manager Related to Manager component comp:common Related to Common component require:db-migration Automatically set when alembic migrations are added or updated area:docs Documentations labels Oct 29, 2025
@HyeockJinKim HyeockJinKim force-pushed the main branch 4 times, most recently from 1a10632 to 2d8c9ea Compare November 23, 2025 14:45
@jopemachine jopemachine marked this pull request as ready for review November 25, 2025 03:52
Copilot AI review requested due to automatic review settings November 25, 2025 03:52
Co-authored-by: octodog <mu001@lablup.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for OpenShift Container Platform (OCP) container registries to the Backend.AI system. The implementation allows users to configure and use OCP registries as a source for container images.

Key changes:

  • Added new "ocp" registry type to the ContainerRegistryType enum
  • Implemented OpenShiftPlatformContainerRegistry class to handle OCP-specific registry operations
  • Increased registry_name column length from 50 to 255 characters to accommodate longer OCP registry names

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ai/backend/common/container_registry.py Added OCP enum value to ContainerRegistryType
src/ai/backend/manager/models/container_registry.py Increased registry_name field length to 255 characters
src/ai/backend/manager/models/alembic/versions/b0fb0eb6b6bc_remove_container_registries_registry_.py Database migration to update registry_name column length
src/ai/backend/manager/container_registry/ocp.py New OCP registry implementation using Docker Registry API v2
src/ai/backend/manager/container_registry/init.py Added OCP registry type to factory function
fixtures/manager/example-container-registries-ocp.json Example configuration for OCP registry
docs/manager/rest-reference/openapi.json Updated OpenAPI schema with ocp type
docs/manager/graphql-reference/supergraph.graphql Updated GraphQL documentation with ocp type
docs/manager/graphql-reference/schema.graphql Updated GraphQL schema documentation with ocp type
changes/6464.feature.md Changelog entry for OCP support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread src/ai/backend/manager/container_registry/ocp.py
@jopemachine jopemachine added this to the 25.18 milestone Nov 25, 2025

@seedspirit seedspirit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any additional OCP registry metadata validation logic to be added to ContainerRegistryValidator?

@jopemachine

Copy link
Copy Markdown
Member Author

Is there any additional OCP registry metadata validation logic to be added to ContainerRegistryValidator?

No, these PR changes are unrelated to ContainerRegistryValidator.
What made you think so? @seedspirit

@seedspirit

seedspirit commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

No, these PR changes are unrelated to ContainerRegistryValidator.

When attempting to register a registry with the Container Registry Type set to Harbor, validations are performed such as checking the registry name length, whether a project has been entered, and whether the project name pattern is correct. I was wondering whether OCP also requires such validations. @jopemachine

@jopemachine

jopemachine commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

I've added ContainerRegistryValidator for checking project length check which could be different according to the registry type.
I couldn't find information on project length limits on the OCP registry, (But it can be easily added if needed)

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit 54d956e Nov 27, 2025
31 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/support_ocr branch November 27, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:docs Documentations comp:common Related to Common component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support OCP (OpenShift Container Platform) Registry

4 participants