feat(BA-2850): Support OCP Container Registry#6464
Conversation
1a10632 to
2d8c9ea
Compare
77f1ecf to
5f6fca5
Compare
Co-authored-by: octodog <mu001@lablup.com>
There was a problem hiding this comment.
Pull request overview
This PR adds support for OpenShift Container Platform (OCP) container registries to the Backend.AI system. The implementation allows users to configure and use OCP registries as a source for container images.
Key changes:
- Added new "ocp" registry type to the ContainerRegistryType enum
- Implemented OpenShiftPlatformContainerRegistry class to handle OCP-specific registry operations
- Increased registry_name column length from 50 to 255 characters to accommodate longer OCP registry names
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ai/backend/common/container_registry.py | Added OCP enum value to ContainerRegistryType |
| src/ai/backend/manager/models/container_registry.py | Increased registry_name field length to 255 characters |
| src/ai/backend/manager/models/alembic/versions/b0fb0eb6b6bc_remove_container_registries_registry_.py | Database migration to update registry_name column length |
| src/ai/backend/manager/container_registry/ocp.py | New OCP registry implementation using Docker Registry API v2 |
| src/ai/backend/manager/container_registry/init.py | Added OCP registry type to factory function |
| fixtures/manager/example-container-registries-ocp.json | Example configuration for OCP registry |
| docs/manager/rest-reference/openapi.json | Updated OpenAPI schema with ocp type |
| docs/manager/graphql-reference/supergraph.graphql | Updated GraphQL documentation with ocp type |
| docs/manager/graphql-reference/schema.graphql | Updated GraphQL schema documentation with ocp type |
| changes/6464.feature.md | Changelog entry for OCP support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: octodog <mu001@lablup.com>
seedspirit
left a comment
There was a problem hiding this comment.
Is there any additional OCP registry metadata validation logic to be added to ContainerRegistryValidator?
No, these PR changes are unrelated to ContainerRegistryValidator. |
When attempting to register a registry with the Container Registry Type set to Harbor, validations are performed such as checking the registry name length, whether a project has been entered, and whether the project name pattern is correct. I was wondering whether OCP also requires such validations. @jopemachine |
|
I've added |
resolves #6467 (BA-2850)
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--6464.org.readthedocs.build/en/6464/
📚 Documentation preview 📚: https://sorna-ko--6464.org.readthedocs.build/ko/6464/