Skip to content

refactor(BA-5046): migrate artifact registry action classes to RBAC base classes #9992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregataa merged 3 commits into from
Mar 20, 2026
Merged

refactor(BA-5046): migrate artifact registry action classes to RBAC base classes #9992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9aac93b
refactor(BA-5046): migrate artifact registry action classes to RBAC b…
fregataa Mar 12, 2026
31a745f
changelog: add news fragment for PR #9992
fregataa Mar 12, 2026
3e0b7c2
fix(BA-5046): raise InvalidAPIParameters when both registry_id and re…
fregataa Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/9992.enhance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Refactor artifact registry action classes to RBAC-aware base classes (`ArtifactRegistrySingleEntityAction`) to enable RBAC validator wiring
3 changes: 0 additions & 3 deletions src/ai/backend/manager/services/artifact_registry/actions/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from dataclasses import dataclass
from typing import override

from ai.backend.common.data.permission.types import EntityType
Expand All @@ -11,15 +10,13 @@
from ai.backend.manager.actions.action.types import FieldData


@dataclass
class ArtifactRegistryAction(BaseAction):
@override
@classmethod
def entity_type(cls) -> EntityType:
return EntityType.ARTIFACT_REGISTRY


@dataclass
class ArtifactBatchRegistryAction(BaseBatchAction):
@override
@classmethod
Expand Down
31 changes: 22 additions & 9 deletions src/ai/backend/manager/services/artifact_registry/actions/common/get_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,44 @@
from dataclasses import dataclass
from typing import override

from ai.backend.manager.actions.action import BaseActionResult
from ai.backend.common.data.permission.types import RBACElementType
from ai.backend.manager.actions.types import ActionOperationType
from ai.backend.manager.data.artifact_registries.types import ArtifactRegistryData
from ai.backend.manager.services.artifact_registry.actions.base import ArtifactRegistryAction
from ai.backend.manager.data.permission.types import RBACElementRef
from ai.backend.manager.errors.api import InvalidAPIParameters
from ai.backend.manager.services.artifact_registry.actions.base import (
ArtifactRegistrySingleEntityAction,
ArtifactRegistrySingleEntityActionResult,
)


@dataclass
class GetArtifactRegistryMetaAction(ArtifactRegistryAction):
class GetArtifactRegistryMetaAction(ArtifactRegistrySingleEntityAction):
registry_id: uuid.UUID | None = None
registry_name: str | None = None

@override
def entity_id(self) -> str | None:
return str(self.registry_id)

@override
@classmethod
def operation_type(cls) -> ActionOperationType:
return ActionOperationType.GET

@override
def target_entity_id(self) -> str:
if self.registry_id:
Copy link
Copy Markdown
Member

@jopemachine jopemachine Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think registry_name should not be included here

return str(self.registry_id)
if self.registry_name:
return self.registry_name
raise InvalidAPIParameters("Either registry_id or registry_name must be provided.")

@override
def target_element(self) -> RBACElementRef:
return RBACElementRef(RBACElementType.ARTIFACT_REGISTRY, self.target_entity_id())


@dataclass
class GetArtifactRegistryMetaActionResult(BaseActionResult):
class GetArtifactRegistryMetaActionResult(ArtifactRegistrySingleEntityActionResult):
result: ArtifactRegistryData

@override
def entity_id(self) -> str | None:
def target_entity_id(self) -> str:
return str(self.result.id)
9 changes: 7 additions & 2 deletions src/ai/backend/manager/services/artifact_registry/processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class ArtifactRegistryProcessors(AbstractProcessorPackage):
search_reservoir_registries: ActionProcessor[
SearchReservoirRegistriesAction, SearchReservoirRegistriesActionResult
]
get_registry_meta: ActionProcessor[
get_registry_meta: SingleEntityActionProcessor[
GetArtifactRegistryMetaAction, GetArtifactRegistryMetaActionResult
]
get_registry_metas: ActionProcessor[
Expand Down Expand Up @@ -192,14 +192,19 @@ def __init__(
validators=[validators.rbac.single_entity],
)

self.get_registry_meta = SingleEntityActionProcessor(
service.get_registry_meta,
action_monitors,
validators=[validators.rbac.single_entity],
)

# Internal/batch actions without RBAC
self.get_huggingface_registries = ActionProcessor(
service.get_huggingface_registries, action_monitors
)
self.get_reservoir_registries = ActionProcessor(
service.get_reservoir_registries, action_monitors
)
self.get_registry_meta = ActionProcessor(service.get_registry_meta, action_monitors)
self.get_registry_metas = ActionProcessor(service.get_registry_metas, action_monitors)

@override
Expand Down
Loading