fix: align interactive mode authentication with exec mode#17
Merged
Conversation
- Add authentication parameters (key_path, use_agent, use_password, strict_mode) to InteractiveCommand struct - Reuse the same authentication logic from exec mode's determine_auth_method - Pass CLI auth parameters from main.rs to interactive command - Update tests and examples to include new authentication fields This ensures consistent authentication behavior between interactive and exec modes, fixing connection failures when using cluster configurations with SSH keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
key_path,use_agent,use_password,strict_mode) toInteractiveCommandstructdetermine_auth_method()in interactive mode to use the same logic as exec modeProblem Solved
Previously, interactive mode ignored CLI authentication parameters and cluster SSH key configurations, causing connection failures when running commands like
bssh -c orin interactive. The mode had its own simplified authentication logic that only checked for SSH agent and default key locations.Now interactive mode respects:
-i/--identity,--use-agent,--passwordTest Plan
cargo build --all-targetscargo fmt