update: Sync bssh-russh fork with upstream russh 0.60.0#178
Merged
Conversation
Runs crates/bssh-russh/sync-upstream.sh 0.60.0, applies our handle-data-fix PTY patch on top, and bumps the fork's Cargo.toml to match upstream 0.60.0's dependency floor. This pulls in the RustCrypto migration upstream russh already completed: - rand 0.9 -> 0.10 (stable rand_core 0.10.0, no more rc-3 pin) - signature 2.2 -> 3.0.0-rc.10 - ed25519-dalek 2.0 -> 3.0.0-pre.6 - elliptic-curve 0.13 -> 0.14.0-rc.28, p256/p384/p521 0.14.0-rc.7 - ecdsa 0.16 -> 0.17.0-rc.16 - curve25519-dalek 4.1.3 -> 5.0.0-pre.6 - der 0.7 -> 0.8, sec1 0.7 -> 0.8 - pkcs8 0.10 -> 0.11.0-rc.11, pkcs5 0.7 -> 0.8.0-rc.13 - spki 0.7 -> 0.8.0-rc.4 - ml-kem 0.2.3 -> 0.3.0-rc.1 (adds module-lattice 0.2) - num-bigint -> internal-russh-num-bigint 0.5.0 with rand_0_10 feature - ssh-key 0.6.16 -> 0.6.18 - crypto-bigint 0.7.0-rc.28 (added explicit) - tokio 1.50.0 -> 1.51.1 Root crate: bssh-russh version bump 0.59 -> 0.60, rand 0.9 -> 0.10. Key-generation sites now use rand::rng() (rand 0.10's thread RNG which implements the new rand_core 0.10 CryptoRng trait directly), replacing the ssh_key::rand_core::OsRng workaround. PTY fix patch reapplied cleanly to the new session.rs. The sync-upstream script couldn't auto-resolve the target path (patch header uses absolute /tmp paths) so it was applied manually with 'patch src/server/session.rs'. bssh-russh lib tests were broken before and after this sync (missing dev-dependencies for tempfile/env_logger/etc) — pre-existing and out of scope here. Root crate: 1193 lib tests pass, clippy clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs our `bssh-russh` fork with upstream `warp-tech/russh` v0.60.0 and pulls in the RustCrypto migration the upstream already landed. This finally lets us reach rand 0.10 stable in the root crate.
Upstream deltas folded in
Root crate adjustments
Sync process
Test plan