chore(ci): drop clippy+test from release pipeline; keep gate local-only#23
Merged
Merged
Conversation
PR #21 moved clippy+test from PR-time ci.yml to release.yml on the theory that paying ~15 min once per release was cheaper than paying it on every PR push. The first real run came in at ~30+ min on the shared self-hosted Apple Silicon runner, which inverts the trade-off — release builds now block on a slow lint/test pass that `make verify` would have caught locally in seconds. This commit removes the fmt/clippy/test steps from release.yml's `build-macos` job (and reverts the `components: clippy, rustfmt` addition), and updates ci.yml's header comment to document that the quality gate is local-only via `make verify` / `make verify-clean`. PR-time CI keeps cargo-deny + cargo-fmt on ubuntu (cheap, no self-hosted runner involvement). The release pipeline goes back to its pre-#21 shape: build, sign, package, upload.
inureyes
added
status:review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #21 moved
clippy + testfrom PR-timeci.ymlintorelease.yml::build-macoson the assumption that paying ~15 min once per release was cheaper than paying it on every PR push. The first real run came in at ~30+ min on the shared self-hosted Apple Silicon runner, which inverts the trade-off — release builds now block on a slow lint/test pass thatmake verifywould have caught locally in seconds.This PR drops clippy+test from the release pipeline entirely. The quality gate is now local-only, via the
verify*targets introduced in #19.What changed
release.yml— removed frombuild-macos:Format checkstepClippystepTeststepcomponents: clippy, rustfmtfrom the toolchain installThe
build-macosjob is back to its pre-#21 shape: build → sign → package → upload. A long comment block in its place documents why lint/test aren't here and points atmake verify/make verify-clean.ci.yml— header comment updated:make verify,make verify-clean).What didn't change
PR-time CI still runs
cargo-deny+cargo-fmton ubuntu (both are cheap, neither touches the self-hosted runner).pipeline-parallel-ci.ymlis untouched.Trade-off
make verifybefore pushing — otherwise lint/test regressions land onmainuntil somebody runs it locally.make verifyexists, takes ~2 min on a warm cache, and we already use it before every push in practice).