Skip to content

perf: download file error catch #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

perf: download file error catch #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions modules/tool/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,25 @@ export async function downloadTool(objectName: string) {
return rootMod.toolId;
}

try {
const uploadPath = path.join(process.cwd(), 'dist', 'tools', 'uploaded');
const uploadPath = path.join(process.cwd(), 'dist', 'tools', 'uploaded');
if (!fs.existsSync(uploadPath)) {
fs.mkdirSync(uploadPath, { recursive: true });
}

// Upload folder exists
if (!fs.existsSync(uploadPath)) {
fs.mkdirSync(uploadPath, { recursive: true });
}
const filepath = path.join(uploadPath, filename);

const filepath = path.join(uploadPath, filename);
try {
await pipeline(await pluginFileS3Server.getFile(objectName), createWriteStream(filepath));

const extractedToolId = await extractToolIdFromFile(filepath);
if (!extractedToolId) return Promise.reject('Failed to extract toolId from file');
const toolId = await extractToolIdFromFile(filepath);
if (!toolId) return Promise.reject('Failed to extract toolId from file');

return extractedToolId;
return toolId;
} catch (error) {
// clean the undownloaded file
if (fs.existsSync(filepath)) {
await fs.promises.unlink(filepath);
}
addLog.error(`Failed to download/install plugin:`, getErrText(error));
return Promise.reject(error);
}
}