feat: migrate to fastgpt storage sdk by xqvvu · Pull Request #324 · labring/fastgpt-plugin

xqvvu · 2025-12-19T08:32:31Z

No description provided.

github-actions · 2025-12-23T10:36:11Z

✅ Build Successful - Preview Images for this PR:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-plugin-pr:c3f8d91d6c388ebb6d18337a1af8b774dc464888

Changed packages:
base64Decode dalle3 dbops docDiff drawing gptImage markdownTransform mineru minimax openrouterMultiModal stability

.env.marketplace.template

lib/s3/config.ts

lib/s3/index.ts

lib/worker/index.ts

lib/worker/loadTool.ts

modules/tool/api/upload/confirmUpload.ts

modules/tool/constants.ts

modules/tool/type/req.ts

modules/tool/constants.ts

lib/worker/loadTool.ts

c121914yu

试试改一个版本号

Copilot

Pull request overview

This PR migrates the codebase from a custom MinIO-based S3 implementation to the @fastgpt-sdk/storage SDK, which provides unified support for multiple cloud storage vendors including MinIO, AWS S3, Alibaba Cloud OSS, and Tencent Cloud COS.

Key Changes:

Replaced custom S3 client implementation with @fastgpt-sdk/storage SDK
Refactored environment variable configuration to support multiple storage vendors
Updated storage-related APIs to use the new SDK's interface
Added new version entries for multiple tool packages

Reviewed changes

Copilot reviewed 38 out of 40 changed files in this pull request and generated 22 comments.

Show a summary per file

File	Description
sdk/package.json	Bumped package version from 0.2.16 to 0.2.17
scripts/deploy-marketplace.ts	Migrated S3Client usage to createStorage API with multi-vendor support
runtime/index.ts	Removed initializeS3() call as initialization is now handled in lib/s3/index.ts
runtime/.env.template	Replaced old S3 environment variables with new STORAGE_* variables for multi-vendor support
package.json	Added @fastgpt-sdk/storage ^0.5.1 and proxy-agent dependencies
modules/tool/utils/uploadFile.ts	Added global prefix handling for worker-based file uploads
modules/tool/type/req.ts	Added optional prefix field to tool system variables
modules/tool/parseMod.ts	Updated to use new SDK's generateExternalUrl method
modules/tool/loadToolDev.ts	Removed await from generateExternalUrl calls (now synchronous)
modules/tool/constants.ts	Removed leading slash from PluginBaseS3Prefix constant
modules/tool/build/build-json.ts	Updated icon path generation to use new SDK
modules/tool/api/upload/confirmUpload.ts	Added debug logging for downloaded tools
modules/model/avatars.ts	Removed await from generateExternalUrl (now synchronous)
lib/worker/worker.ts	Added global.currentToolPrefix for cross-import state management
lib/worker/loadTool.ts	Moved LoadToolsByFilename implementation from loadToolProd and removed icon path generation
lib/worker/index.ts	Added getInheritEnv helper to pass all environment variables to workers
lib/utils/setupProxy.ts	Simplified proxy setup to use undici's EnvHttpProxyAgent
lib/type/env.d.ts	Removed old S3_* environment variable declarations
lib/s3/index.ts	Completely refactored to use @fastgpt-sdk/storage with lazy initialization
lib/s3/controller.ts	Migrated from minio.Client to IStorage interface
lib/s3/const.ts	Removed PublicBucketBaseURL constant (now handled by SDK)
lib/s3/config.ts	Replaced S3ConfigType with createDefaultStorageOptions function supporting multiple vendors
lib/package.json	Added @fastgpt-sdk/storage 0.5.7 dependency
.github/workflows/deploy-marketplace.yml	Updated environment variables from S3_* to STORAGE_*
.env.marketplace.template	Added comprehensive STORAGE_* configuration options
Multiple tool config files	Added new version entries (0.1.1, 0.1.2, etc.) with updated configurations
modules/tool/packages/dbops/children/oracle/src/index.ts	Improved Oracle DB error handling and result sanitization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

modules/tool/constants.ts

modules/tool/loadToolDev.ts

package.json

lib/s3/index.ts

scripts/deploy-marketplace.ts

modules/tool/packages/dbops/children/oracle/src/index.ts

lib/s3/controller.ts

scripts/deploy-marketplace.ts

Copilot

Pull request overview

Copilot reviewed 37 out of 39 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lib/worker/index.ts

Copilot · 2026-01-06T09:06:29Z

scripts/deploy-marketplace.ts

+      storage.uploadObject({
+        key: `${UploadToolsS3Path}/${toolId}/${childId}/logo`,
+        body: Buffer.from(await Bun.file(childLogo).arrayBuffer()),
+        contentType: mimeMap[ext]
      });


Missing await keyword on storage.uploadObject() call. This async operation is not being awaited, which could result in incomplete uploads when the child has its own logo.

* chore: more logs * feat: migrate to fastgpt storage sdk * chore: add systemVar types * chore: rename env variable * fix: oracle db operation * fix: global proxy agent * fix: incorrect config load timing * fix: incorrect fastgpt storage sdk version * fix: update COS proxy * chore: upgrade tools' version which using 'uploadFile' function * clean code

* feat: migrate to fastgpt storage sdk (#324) * chore: more logs * feat: migrate to fastgpt storage sdk * chore: add systemVar types * chore: rename env variable * fix: oracle db operation * fix: global proxy agent * fix: incorrect config load timing * fix: incorrect fastgpt storage sdk version * fix: update COS proxy * chore: upgrade tools' version which using 'uploadFile' function * clean code * fix: use "minio" for minio adapter (#337) * chore: more logs * clean code * fix: use "minio" for minio adapter * fix: remove log client when ensure public policy failed (#338) * chore: more logs * clean code * fix: remove log client when ensure public policy failed * fix: use minio client to delete files when using minio vendor * chore: bump @fastgpt-sdk/storage (#339) * chore: more logs * clean code * chore: bump @fastgpt-sdk/storage * fix: bump storage sdk (#340) * chore: more logs * clean code * fix: bump storage sdk * perf: worker in tool (#342) * remove run in worker * update plugin version * perf: worker in tool * adapt v1 * adapt v1 * adapt v1 * adapt v1 * update lock * worker * log * log * log * mongo (#343) * mongo * fix: ts * fix: add async context for non-worker environment (#344) * chore: more logs * clean code * fix: add async context for non-worker environment * fix: bundle pkgs without mongo and storage dependencies * fix: force throw error when there is no prefix passing in --------- Co-authored-by: Finley Ge <32237950+FinleyGe@users.noreply.github.com> * fix: mssql authentication (#345) * chore: more logs * clean code * fix: mssql authentication --------- Co-authored-by: roy <whoeverimf5@gmail.com> Co-authored-by: Finley Ge <32237950+FinleyGe@users.noreply.github.com>

pull-request-size bot added the size/XXL label Dec 19, 2025

xqvvu force-pushed the main branch 3 times, most recently from 5a9130f to 2adb9ae Compare December 23, 2025 10:33

xqvvu force-pushed the main branch from 2adb9ae to e971b66 Compare December 23, 2025 10:52

c121914yu reviewed Dec 24, 2025

View reviewed changes

xqvvu force-pushed the main branch 5 times, most recently from 8c43628 to 3520ec3 Compare December 25, 2025 10:11

c121914yu reviewed Jan 6, 2026

View reviewed changes

c121914yu requested a review from Copilot January 6, 2026 03:24

Copilot started reviewing on behalf of c121914yu January 6, 2026 03:24 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

xqvvu force-pushed the main branch from ee0c7dd to 456d68b Compare January 6, 2026 03:37

xqvvu added 10 commits January 6, 2026 15:36

chore: more logs

151b875

feat: migrate to fastgpt storage sdk

0d50090

chore: add systemVar types

84dd3d2

chore: rename env variable

660d0a5

fix: oracle db operation

fba9443

fix: global proxy agent

3193276

fix: incorrect config load timing

af16e40

fix: incorrect fastgpt storage sdk version

c3ad11f

fix: update COS proxy

6a19acd

chore: upgrade tools' version which using 'uploadFile' function

f440fd0

xqvvu force-pushed the main branch 2 times, most recently from 0c61cc8 to d924356 Compare January 6, 2026 07:37

c121914yu changed the base branch from main to v0.4.0-dev January 6, 2026 09:03

c121914yu requested a review from Copilot January 6, 2026 09:03

Copilot started reviewing on behalf of c121914yu January 6, 2026 09:03 View session

c121914yu approved these changes Jan 6, 2026

View reviewed changes

Copilot AI reviewed Jan 6, 2026

View reviewed changes

xqvvu force-pushed the main branch from d924356 to ac40766 Compare January 6, 2026 09:09

clean code

c3f8d91

xqvvu force-pushed the main branch from ac40766 to c3f8d91 Compare January 6, 2026 09:27

c121914yu approved these changes Jan 6, 2026

View reviewed changes

c121914yu merged commit 8d871b1 into labring:v0.4.0-dev Jan 6, 2026
2 checks passed

Conversation

xqvvu commented Dec 19, 2025

Uh oh!

github-actions bot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

c121914yu left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 23, 2025 •

edited

Loading