perf: move third party dataset to plugin#350
Closed
newfish-cmyk wants to merge 5 commits intolabring:dev/v0.5.0from
Closed
perf: move third party dataset to plugin#350newfish-cmyk wants to merge 5 commits intolabring:dev/v0.5.0from
newfish-cmyk wants to merge 5 commits intolabring:dev/v0.5.0from
Conversation
|
✅ Build Successful - Preview Images for this PR: Changed packages: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new plugin-based dataset module that supports third-party data sources (Yuque and Feishu) for building knowledge bases. The implementation follows a modular, extensible architecture with proper TypeScript typing, contract definitions, and S3-based avatar management.
Changes:
- Added new dataset module with support for Yuque and Feishu data sources
- Implemented plugin-based registry system for extensible data source management
- Added S3-based avatar/logo handling for dataset sources with both color and outline versions
Reviewed changes
Copilot reviewed 17 out of 22 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Added @dataset/* path mapping for the new dataset module |
| runtime/tsconfig.json | Added @dataset/* path mapping for runtime environment |
| sdk/client.ts | Exported dataset source types for SDK consumers |
| modules/dataset/type/source.ts | Defined core type schemas for dataset sources, form fields, and file operations |
| modules/dataset/type/index.ts | Re-exported dataset types |
| modules/dataset/sources/yuque/* | Implemented Yuque knowledge base integration with API client and configuration |
| modules/dataset/sources/feishu/* | Implemented Feishu document integration with token caching and API client |
| modules/dataset/source/registry.ts | Created registry pattern for managing dataset source plugins |
| modules/dataset/source/index.ts | Exported registry utilities |
| modules/dataset/router.ts | Implemented REST API endpoints for dataset source operations |
| modules/dataset/contract.ts | Defined API contracts using Zod schemas |
| modules/dataset/avatars.ts | Implemented S3-based logo management for both development and production |
| runtime/build/index.ts | Added build step to copy dataset source avatars to dist directory |
| runtime/index.ts | Integrated dataset avatar initialization into startup sequence |
| lib/router/index.ts | Registered dataset router in main application router |
| lib/contract/index.ts | Added dataset contract to main API contract |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c121914yu
reviewed
Jan 28, 2026
3ce0409 to
4bc96f4
Compare
4bc96f4 to
c0b56e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.