Skip to content

udpate action#395

Merged
c121914yu merged 1 commit intolabring:mainfrom
c121914yu:test-tool
Mar 21, 2026
Merged

udpate action#395
c121914yu merged 1 commit intolabring:mainfrom
c121914yu:test-tool

Conversation

@c121914yu
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 21, 2026 05:12
@c121914yu c121914yu merged commit 55ce2b9 into labring:main Mar 21, 2026
1 of 2 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the container image build workflow to use a new set of GitHub Secrets for logging into and tagging images for the Aliyun container registry.

Changes:

  • Swaps Aliyun registry credentials secrets to FASTGPT_ALI_IMAGE_USER / FASTGPT_ALI_IMAGE_PSW.
  • Swaps Aliyun image name/prefix secret to FASTGPT_ALI_IMAGE_PREFIX for tag construction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +102 to +103
username: ${{ secrets.FASTGPT_ALI_IMAGE_USER }}
password: ${{ secrets.FASTGPT_ALI_IMAGE_PSW }}
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These secret names changed; the workflow will fail at runtime unless the repo/org secrets FASTGPT_ALI_IMAGE_USER and FASTGPT_ALI_IMAGE_PSW are configured (and any previous secrets referenced by this workflow are no longer needed). Please confirm the secrets exist in the target environment(s) where this workflow runs.

Copilot uses AI. Check for mistakes.
Comment on lines +113 to +115
ALI_TAG="${{ secrets.FASTGPT_ALI_IMAGE_PREFIX }}/fastgpt-plugin:${{ github.ref_name }}"
ALI_LATEST="${{ secrets.FASTGPT_ALI_IMAGE_PREFIX }}/fastgpt-plugin:latest"
ALI_SHA="${{ secrets.FASTGPT_ALI_IMAGE_PREFIX }}/fastgpt-plugin:${{ github.sha }}"
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALI_TAG/ALI_LATEST/ALI_SHA are built from secrets.FASTGPT_ALI_IMAGE_PREFIX. For pushes to Aliyun, the image tag must include the registry host (e.g., registry.cn-hangzhou.aliyuncs.com/<namespace>), otherwise docker buildx imagetools create -t ... will target Docker Hub by default. Please ensure this secret is defined in that full form.

Suggested change
ALI_TAG="${{ secrets.FASTGPT_ALI_IMAGE_PREFIX }}/fastgpt-plugin:${{ github.ref_name }}"
ALI_LATEST="${{ secrets.FASTGPT_ALI_IMAGE_PREFIX }}/fastgpt-plugin:latest"
ALI_SHA="${{ secrets.FASTGPT_ALI_IMAGE_PREFIX }}/fastgpt-plugin:${{ github.sha }}"
# Ensure Aliyun image tags include the full registry host
ALI_PREFIX="registry.cn-hangzhou.aliyuncs.com/${{ secrets.FASTGPT_ALI_IMAGE_PREFIX }}"
ALI_TAG="$ALI_PREFIX/fastgpt-plugin:${{ github.ref_name }}"
ALI_LATEST="$ALI_PREFIX/fastgpt-plugin:latest"
ALI_SHA="$ALI_PREFIX/fastgpt-plugin:${{ github.sha }}"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants