Skip to content

feat(plugin): normalize tool parameter metadata#502

Open
FinleyGe wants to merge 5 commits into
labring:mainfrom
FinleyGe:codex/istoolparams
Open

feat(plugin): normalize tool parameter metadata#502
FinleyGe wants to merge 5 commits into
labring:mainfrom
FinleyGe:codex/istoolparams

Conversation

@FinleyGe

@FinleyGe FinleyGe commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add optional isToolParam input schema metadata across sdk-factory types, docs, skills, CLI templates, and fixtures
  • normalize tool detail input schema metadata for root tools and toolset children
  • preserve explicit isToolParam values while falling back toolDescription from description.en when needed

Validation

  • ./node_modules/.bin/vitest run sdk/factory/src/tool-factory.test.ts packages/infrastructure/src/plugin/tool.impl.test.ts
  • ./node_modules/.bin/eslint sdk/factory/src/index.ts sdk/factory/src/tool-factory.test.ts packages/infrastructure/src/plugin/tool.impl.ts packages/infrastructure/src/plugin/tool.impl.test.ts
  • git diff --check upstream/main...HEAD

Note: full ./node_modules/.bin/tsc --noEmit still reports the existing unrelated StreamData type error in sdk/factory/src/tool-factory.test.ts.

@FinleyGe
FinleyGe marked this pull request as draft July 9, 2026 04:12
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Build Successful - Preview Server image for this PR:

ghcr.io/labring/fastgpt-plugin-pr:server_e513aa753e2d320a67947707a2262cc68e930a68

Time: 2026-07-21 17:53:12 (UTC+8)

@FinleyGe
FinleyGe force-pushed the codex/istoolparams branch from 00153ea to de45293 Compare July 16, 2026 07:54
@FinleyGe
FinleyGe marked this pull request as ready for review July 20, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant