fix: handle stale PVC app ownerReferences#31
Merged
zijiren233 merged 1 commit intoMay 26, 2026
Conversation
wallyxjh
force-pushed
the
fix/pvc-ownerrefs-cluster
branch
from
4781297 to
efb9553
Compare
zijiren233
requested changes
May 26, 2026
| if len(refs) == 0 { | ||
| return refs | ||
| } | ||
| retained := refs[:0] |
Member
There was a problem hiding this comment.
Use a brand-new slice instead of referencing the old one to avoid long-term references or destructive changes to the slice’s content.
wallyxjh
force-pushed
the
fix/pvc-ownerrefs-cluster
branch
from
efb9553 to
d863170
Compare
zijiren233
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing