feat(terminal): migrate from manifests to helm charts#6644
Merged
bxy4543 merged 1 commit intolabring:mainfrom Feb 2, 2026
Merged
feat(terminal): migrate from manifests to helm charts#6644bxy4543 merged 1 commit intolabring:mainfrom
bxy4543 merged 1 commit intolabring:mainfrom
Conversation
Refactor terminal controller deployment to use Helm charts for better manageability, following the pattern established by account controller. Major changes: - Replace manifests with Helm chart structure - Add terminal-controller-entrypoint.sh for automated deployment - Remove kube-rbac-proxy sidecar container - Remove kube-proxy-rbac (metrics-reader and proxy-role) - Metrics now bind to 127.0.0.1:8080 (internal only) - Update values.yaml with full image name format - Namespace created via helm --create-namespace flag - Support resource backup, adopt, and auto-configuration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
cuisongliu
approved these changes
Feb 2, 2026
Contributor
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
Refactor terminal controller deployment to use Helm charts for better manageability, following the pattern established by account controller. Major changes: - Replace manifests with Helm chart structure - Add terminal-controller-entrypoint.sh for automated deployment - Remove kube-rbac-proxy sidecar container - Remove kube-proxy-rbac (metrics-reader and proxy-role) - Metrics now bind to 127.0.0.1:8080 (internal only) - Update values.yaml with full image name format - Namespace created via helm --create-namespace flag - Support resource backup, adopt, and auto-configuration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
cuisongliu
pushed a commit
that referenced
this pull request
Feb 2, 2026
feat(terminal): migrate from manifests to helm charts (#6644) Refactor terminal controller deployment to use Helm charts for better manageability, following the pattern established by account controller. Major changes: - Replace manifests with Helm chart structure - Add terminal-controller-entrypoint.sh for automated deployment - Remove kube-rbac-proxy sidecar container - Remove kube-proxy-rbac (metrics-reader and proxy-role) - Metrics now bind to 127.0.0.1:8080 (internal only) - Update values.yaml with full image name format - Namespace created via helm --create-namespace flag - Support resource backup, adopt, and auto-configuration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Jiahui <4543bxy@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
Deployment Structure
manifests/withcharts/terminal-controller/terminal-controller-entrypoint.shfor automated deploymentKubefileto use Helm chartsRBAC & Security
kube-rbac-proxycontainer from deploymentterminal-metrics-readerClusterRoleterminal-proxy-roleandterminal-proxy-rolebindingConfiguration
values.yamluses full image name formathelm --create-namespacesealos-configConfigMapTest Plan
sealos build -t labring/sealos-terminal-controller:latest -f Kubefile .sealos run labring/sealos-terminal-controller:latest🤖 Generated with Claude Code