Skip to content

refactor(node): standardize node-controller deployment structure#6691

Open
bxy4543 wants to merge 1 commit intolabring:mainfrom
bxy4543:charts/node-controller
Open

refactor(node): standardize node-controller deployment structure#6691
bxy4543 wants to merge 1 commit intolabring:mainfrom
bxy4543:charts/node-controller

Conversation

@bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Feb 10, 2026

This commit refactors the node-controller deployment directory to align with the standardized deployment structure used across Sealos services, following the pattern established by account-controller.

Major changes:

  • Rename chart directory from 'node' to 'node-controller' for consistency
  • Remove deprecated 'drop' directory and manifest-based deployment
  • Consolidate RBAC configuration into a single rbac.yaml file
  • Update entrypoint script to use Helm resource adoption instead of kubectl delete
  • Implement Issuer + Certificate pattern for TLS certificate management
  • Disable metrics by default to reduce resource consumption
  • Add comprehensive README.md with deployment guide and usage examples
  • Standardize naming conventions across all templates (node → node-controller)
  • Update Kubefile to reference the renamed entrypoint script
  • Add imagePullPolicy and fullnameOverride to values.yaml

Deployment improvements:

  • Resource adoption mechanism for seamless upgrades from legacy deployments
  • Unified Helm chart structure following account-controller pattern
  • Enhanced security with Issue + Cert approach instead of kube-proxy-rbac
  • Cleaner directory structure without manifest files

Documentation:

  • Complete README.md with quick start, configuration reference, and troubleshooting
  • Clear usage examples for common deployment scenarios

This refactor maintains backward compatibility through Helm resource adoption while providing a cleaner, more maintainable deployment structure.

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

Conflicts:

controllers/node/deploy/charts/node/templates/configmap.yaml # controllers/node/deploy/drop/deploy.yaml

This commit refactors the node-controller deployment directory to align
with the standardized deployment structure used across Sealos services,
following the pattern established by account-controller.

Major changes:
- Rename chart directory from 'node' to 'node-controller' for consistency
- Remove deprecated 'drop' directory and manifest-based deployment
- Consolidate RBAC configuration into a single rbac.yaml file
- Update entrypoint script to use Helm resource adoption instead of kubectl delete
- Implement Issuer + Certificate pattern for TLS certificate management
- Disable metrics by default to reduce resource consumption
- Add comprehensive README.md with deployment guide and usage examples
- Standardize naming conventions across all templates (node → node-controller)
- Update Kubefile to reference the renamed entrypoint script
- Add imagePullPolicy and fullnameOverride to values.yaml

Deployment improvements:
- Resource adoption mechanism for seamless upgrades from legacy deployments
- Unified Helm chart structure following account-controller pattern
- Enhanced security with Issue + Cert approach instead of kube-proxy-rbac
- Cleaner directory structure without manifest files

Documentation:
- Complete README.md with quick start, configuration reference, and troubleshooting
- Clear usage examples for common deployment scenarios

This refactor maintains backward compatibility through Helm resource adoption
while providing a cleaner, more maintainable deployment structure.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

# Conflicts:
#	controllers/node/deploy/charts/node/templates/configmap.yaml
#	controllers/node/deploy/drop/deploy.yaml
@bxy4543 bxy4543 requested a review from a team as a code owner February 10, 2026 12:55
@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant