refactor(node): standardize node-controller deployment structure#6691
Open
bxy4543 wants to merge 1 commit intolabring:mainfrom
Open
refactor(node): standardize node-controller deployment structure#6691bxy4543 wants to merge 1 commit intolabring:mainfrom
bxy4543 wants to merge 1 commit intolabring:mainfrom
Conversation
This commit refactors the node-controller deployment directory to align with the standardized deployment structure used across Sealos services, following the pattern established by account-controller. Major changes: - Rename chart directory from 'node' to 'node-controller' for consistency - Remove deprecated 'drop' directory and manifest-based deployment - Consolidate RBAC configuration into a single rbac.yaml file - Update entrypoint script to use Helm resource adoption instead of kubectl delete - Implement Issuer + Certificate pattern for TLS certificate management - Disable metrics by default to reduce resource consumption - Add comprehensive README.md with deployment guide and usage examples - Standardize naming conventions across all templates (node → node-controller) - Update Kubefile to reference the renamed entrypoint script - Add imagePullPolicy and fullnameOverride to values.yaml Deployment improvements: - Resource adoption mechanism for seamless upgrades from legacy deployments - Unified Helm chart structure following account-controller pattern - Enhanced security with Issue + Cert approach instead of kube-proxy-rbac - Cleaner directory structure without manifest files Documentation: - Complete README.md with quick start, configuration reference, and troubleshooting - Clear usage examples for common deployment scenarios This refactor maintains backward compatibility through Helm resource adoption while providing a cleaner, more maintainable deployment structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> # Conflicts: # controllers/node/deploy/charts/node/templates/configmap.yaml # controllers/node/deploy/drop/deploy.yaml
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the node-controller deployment directory to align with the standardized deployment structure used across Sealos services, following the pattern established by account-controller.
Major changes:
Deployment improvements:
Documentation:
This refactor maintains backward compatibility through Helm resource adoption while providing a cleaner, more maintainable deployment structure.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Conflicts:
controllers/node/deploy/charts/node/templates/configmap.yaml # controllers/node/deploy/drop/deploy.yaml