feat(template): support extra resource labels#6992
Open
zjy365 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extraLabelssupport to the template v2alpha create-instance and raw deploy APIs.extraLabelsin the v2alpha request schemas and reject reserved Sealos ownership labels.Why
External orchestrators need a supported way to attach their own ownership labels to resources rendered by template deployment, without overriding Sealos labels used for instance lookup and lifecycle management.
Validation
pnpm --filter template test:ci -- template-extra-labelsgit diff --checkpnpm exec prettier --check providers/template/src/pages/api/v2alpha/templates/instances.ts providers/template/src/pages/api/v2alpha/templates/raw.ts providers/template/src/types/apis/v2alpha/create-instance.ts providers/template/src/types/apis/v2alpha/deploy-template.ts providers/template/src/utils/common.ts providers/template/src/utils/json-yaml.ts providers/template/src/utils/template.ts providers/template/__tests__/template-extra-labels.test.tspnpm --filter template buildpnpm --filter template buildpasses with existing React Hook lint warnings in unrelated files.