Add Wander Connect Strategy #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danziger
reviewed
May 29, 2025
| // Handle authentication result | ||
| if (authInfo.authStatus === "authenticated") { | ||
| this._isAuthenticated = true; | ||
| this._arweaveWallet = window.arweaveWallet; |
There was a problem hiding this comment.
It would be better to do this by listening to window.addEventListener("arweaveWalletLoaded", handleWalletLoaded);. Also, this is the event you should be listening to before calling connect()
Danziger
reviewed
May 29, 2025
| if (authInfo.authStatus === "authenticated") { | ||
| this._isAuthenticated = true; | ||
| this._arweaveWallet = window.arweaveWallet; | ||
| this._wanderConnect.close(); |
There was a problem hiding this comment.
We should probably move this option to the Connect SDK (closeAfterAuth).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a strategy for Wander Connect
Users can pass the options parameter for Wander Connect's SDK constructor on the WanderConnectStrategy constructor, when creating the instances for each strategy
To simplify the integration, it hides the Wander BE button within Wander Connect because users can add that in AWK as a separate strategy. It also doesn't show the WC button nor the iframe with the wallet dashboard because AWK abstracts the usage of the wallet to avoid dealing with different UIs
It is also included in the AWK React Legacy package by default