Skip to content

Conversation

@yuya-morimoto
Copy link
Contributor

Summary

This PR fixes a typo where searchIndex += +len(search) was incorrectly written with
duplicate plus operators. The correct expression should be searchIndex += len(search).

Description

Problem

In router.go at line 695, there is a syntax error with duplicate plus operators:

searchIndex += +len(search)

While Go interprets this as searchIndex = searchIndex + (+len(search)) (treating the
second + as a unary plus operator), it's clearly a typo and not the intended expression.

Solution

Changed the expression to the correct form:

searchIndex += len(search)

Impact

• Functionality: The behavior remains the same since Go's unary plus operator doesn't
change the value, but the code is now clearer and matches the intended logic.
• Readability: Improves code clarity by removing the confusing duplicate operator.

Testing

• Existing tests should continue to pass as the functional behavior is unchanged
• The fix is in the router's backtracking logic for "any" node matching

Location

• File: router.go
• Line: 695
• Function: Router.Find()

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.39%. Comparing base (f24aaff) to head (a9fcb3c).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   93.25%   93.39%   +0.14%     
==========================================
  Files          39       39              
  Lines        4652     4666      +14     
==========================================
+ Hits         4338     4358      +20     
+ Misses        218      214       -4     
+ Partials       96       94       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aldas aldas merged commit 40e2e8f into labstack:master Oct 7, 2025
23 of 29 checks passed
@aldas
Copy link
Contributor

aldas commented Oct 7, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants