Fix duplicate plus operator in router backtracking logic #2832
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a typo where searchIndex += +len(search) was incorrectly written with
duplicate plus operators. The correct expression should be searchIndex += len(search).
Description
Problem
In router.go at line 695, there is a syntax error with duplicate plus operators:
searchIndex += +len(search)
While Go interprets this as searchIndex = searchIndex + (+len(search)) (treating the
second + as a unary plus operator), it's clearly a typo and not the intended expression.
Solution
Changed the expression to the correct form:
searchIndex += len(search)
Impact
• Functionality: The behavior remains the same since Go's unary plus operator doesn't
change the value, but the code is now clearer and matches the intended logic.
• Readability: Improves code clarity by removing the confusing duplicate operator.
Testing
• Existing tests should continue to pass as the functional behavior is unchanged
• The fix is in the router's backtracking logic for "any" node matching
Location
• File: router.go
• Line: 695
• Function: Router.Find()