Bump formidable version to ^3.5.4 #1832
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mureinik
force-pushed
the
formidble-3.5.2
branch
2 times, most recently
from
cdf7b16 to
9e5ce96
Compare
mureinik
changed the title
3 tasks
Although it doesn't explicitly state it, [email protected] uses os.machine (https://nodejs.org/api/os.html#osmachine) that was introduced in Node.js 18.9.0 (and then backported to 16.18.0). Since superagent should support Node.js 14.18.0 and above, it cannot use this new version of formidable. Bumping the requirement to ^3.5.4 solves this issue. Fixes ladjs#1831
mureinik
force-pushed
the
formidble-3.5.2
branch
from
9e5ce96 to
5feb4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it doesn't explicitly state it, [email protected] uses
os.machinethat was introduced in Node.js 18.9.0 (and then backported to 16.18.0).[email protected] fixes this issue, so in most cases this problem would go undetected. However, there's still a chance a project that uses superagent or one of its dependencies explicitly requires [email protected], and would thus break under older Node.js versions.
Bumping the requirement to formidable@^3.5.4 solve this potential issue.
Fixes #1831
Checklist