Skip to content

feat: implement from_xml Spark function #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anarefolio wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: implement from_xml Spark function #2098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0565d15
feat: implement from_xml Spark function [tests]
anarefolio Jun 18, 2026
2b0392d
apply rustfmt formatting [tests]
anarefolio Jun 18, 2026
808a739
fix: correct empty tag, attributePrefix and valueTag handling in from…
anarefolio Jun 18, 2026
e550bff
test: add FLOAT and FAILFAST scenarios to from_xml.feature [tests]
anarefolio Jun 18, 2026
91311b8
test: remove FAILFAST scenario [tests]
anarefolio Jun 18, 2026
8f5e32b
feat: add DECIMAL support to from_xml [tests]
anarefolio Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/sail-execution/proto/sail/plan/physical.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ message ExtendedScalarUdf {
SparkToXmlUdf spark_to_xml = 29;
SparkBinUdf spark_bin = 30;
SparkNegativeUdf spark_negative = 31;
SparkFromXmlUdf spark_from_xml = 32;
}
}

Expand Down Expand Up @@ -171,6 +172,10 @@ message SparkToXmlUdf {
string session_timezone = 1;
}

message SparkFromXmlUdf {
string session_timezone = 1;
}

message SparkUnixTimestampUdf {
string timezone = 1;
}
Expand Down
8 changes: 8 additions & 0 deletions crates/sail-execution/src/codec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ use sail_function::scalar::variant::spark_to_variant_object::SparkToVariantObjec
use sail_function::scalar::variant::spark_variant_explode::SparkVariantExplodeUdf;
use sail_function::scalar::variant::spark_variant_get::SparkVariantGet;
use sail_function::scalar::variant::spark_variant_to_json::SparkVariantToJsonUdf;
use sail_function::scalar::xml::from_xml::SparkFromXml;
use sail_function::scalar::xml::to_xml::SparkToXml;
use sail_function::scalar::xml::xpath::Xpath;
use sail_function::scalar::xml::xpath_typed::{xpath_typed_name_to_kind, XpathTyped};
Expand Down Expand Up @@ -2196,6 +2197,10 @@ impl PhysicalExtensionCodec for RemoteExecutionCodec {
let udf = SparkToXml::new(Arc::from(session_timezone));
return Ok(Arc::new(ScalarUDF::from(udf)));
}
UdfKind::SparkFromXml(gen::SparkFromXmlUdf { session_timezone }) => {
let udf = SparkFromXml::new(Arc::from(session_timezone));
return Ok(Arc::new(ScalarUDF::from(udf)));
}
UdfKind::SparkUnixTimestamp(gen::SparkUnixTimestampUdf { timezone }) => {
let udf = SparkUnixTimestamp::new(Arc::from(timezone));
return Ok(Arc::new(ScalarUDF::from(udf)));
Expand Down Expand Up @@ -2657,6 +2662,9 @@ impl PhysicalExtensionCodec for RemoteExecutionCodec {
} else if let Some(func) = node.inner().downcast_ref::<SparkToXml>() {
let session_timezone = func.session_timezone().to_string();
UdfKind::SparkToXml(gen::SparkToXmlUdf { session_timezone })
} else if let Some(func) = node.inner().downcast_ref::<SparkFromXml>() {
let session_timezone = func.session_timezone().to_string();
UdfKind::SparkFromXml(gen::SparkFromXmlUdf { session_timezone })
} else if let Some(func) = node.inner().downcast_ref::<SparkUnixTimestamp>() {
let timezone = func.timezone().to_string();
UdfKind::SparkUnixTimestamp(gen::SparkUnixTimestampUdf { timezone })
Expand Down
Loading
Loading