fix: update CORS config to include write methods and wildcard headers#93
fix: update CORS config to include write methods and wildcard headers#93
Conversation
- Add POST, PUT, DELETE to AllowedMethods (was read-only GET, HEAD) - Use wildcard AllowedHeaders instead of specific headers - Update ExposeHeaders to ETag and x-amz-version-id - Update description text and explanation table accordingly
WalkthroughUpdates CORS configuration guidance in the dialog component from read-only Iceberg metadata access to read/write Iceberg data operations, broadening HTTP methods, expanding headers, and adjusting cache and exposure settings accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/CorsConfigDialog.vue`:
- Around line 59-60: The sample and description referencing AllowedHeaders
currently imply that AllowedHeaders: * covers Authorization which is incorrect;
update the AllowedHeaders sample in CorsConfigDialog.vue (the AllowedHeaders
sample and its descriptive text) to explicitly include "Authorization" (e.g.,
list Authorization, Range, Content-Type, etc.) or else change the description to
state that Authorization is not covered by a wildcard and must be listed when
credentialed requests are used; modify the text near the AllowedHeaders sample
and the sample value itself so they are consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d6fbf9f7-b5fe-463c-bac0-a3e7475b4b63
📒 Files selected for processing (1)
src/components/CorsConfigDialog.vue
Changes
*) for AllowedHeaders instead of listing specific headersETagandx-amz-version-idSummary by CodeRabbit