Skip to content

Wait for create_ap to exit after AP-ENABLED in UI #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakinduakash merged 2 commits into from
Jul 15, 2025
Merged

Wait for create_ap to exit after AP-ENABLED in UI #474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb3ebb9
Wait for create_ap to exit after AP-ENABLED in UI
joanbm May 3, 2025
b41885b
Merge branch 'master' into ui-pclose-on-ap-enabled
lakinduakash Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ui/ui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,7 @@ static void *run_create_hp_shell(void *cmd) {

if (strstr(buf, AP_ENABLED) != NULL) {
init_running_info(NULL);
pclose(fp);
Copy link

Copilot AI Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider checking the return value of pclose(fp) to detect and handle potential errors when closing the pipe to the create_ap process.

Suggested change
pclose(fp);
int pclose_status = pclose(fp);
if (pclose_status != 0) {
printf("Error: pclose() failed with status %d\n", pclose_status);
init_running_info(NULL);
return NULL;
}

Copilot uses AI. Check for mistakes.
return 0;
}
}
Expand Down