Skip to content

feat: add @extrakto_alt and @extrakto_prefix_name options - #133

Merged
laktak merged 4 commits into
laktak:masterfrom
marcdeop:add-name-and-prefix
Jul 27, 2025
Merged

feat: add @extrakto_alt and @extrakto_prefix_name options#133
laktak merged 4 commits into
laktak:masterfrom
marcdeop:add-name-and-prefix

Conversation

@marcdeop

@marcdeop marcdeop commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

By default, extrakto_plugin is only showing alternative options to filters and prefixing the results with the name filter whenever we trigger the all filters option.

extrakto provides us the option to enable or disable both the filter alternatives and the prefixing of the names.

This code allows this option in our plugin.

The code has been modified to follow what was suggested by @laktak in his comment

Option Default Description
@extrakto_alt all Show alternative filters. Possible values are: all to only show them for the all filter, any for any filter and none for never.
@extrakto_prefix_name all Prefix the results with the filter name. Possible values are: all to only show the prefix for the all filter, any for any filter and none for never.

Important note: this code does not affect the line filter ( haven't dig through the code enough to know why this one behaves a bit differently 😅 )

marcdeop added 2 commits July 20, 2025 12:36
By default, extrakto_plugin is only showing alternative options to
filters and prefixing the results with the name filter whenever we
trigger the `all` filters option.

extrakto provides us the option to enable or disable both the filter
alternatives and the prefixing of the names.

This commits allows this option our plugin
@marcdeop
marcdeop marked this pull request as draft July 20, 2025 13:07
@marcdeop
marcdeop force-pushed the add-name-and-prefix branch from ecf524c to 07ac8fc Compare July 20, 2025 14:18
@marcdeop
marcdeop marked this pull request as ready for review July 20, 2025 14:56
@laktak

laktak commented Jul 22, 2025

Copy link
Copy Markdown
Owner

Thanks, this is a great idea!

I do have a suggestion - wouldn't it be even better to change the new options from bool to

Option Default Description
@extrakto_alt all Show alternative filters. Possible values are: all to only show them for the all filter, any for any filter and none for never.
@extrakto_prefix_name all Prefix the results with the filter name. Possible values are: all to only show the prefix for the all filter, any for any filter and none for never.

@marcdeop

Copy link
Copy Markdown
Contributor Author

Thanks, this is a great idea!

I do have a suggestion - wouldn't it be even better to change the new options from bool to
Option Default Description
@extrakto_alt all Show alternative filters. Possible values are: all to only show them for the all filter, any for any filter and none for never.
@extrakto_prefix_name all Prefix the results with the filter name. Possible values are: all to only show the prefix for the all filter, any for any filter and none for never.

This requires a couple of small changes but it sounds legit.

I will try to adjust in the next days.

Thanks for the suggestion @laktak

@marcdeop
marcdeop force-pushed the add-name-and-prefix branch from dd09b96 to f3ddc57 Compare July 24, 2025 17:07
@marcdeop

Copy link
Copy Markdown
Contributor Author

Code has been updated @laktak . It would be cool if you could have another look.

Thanks!

@laktak

laktak commented Jul 27, 2025

Copy link
Copy Markdown
Owner

Perfect, thank you!

@laktak
laktak merged commit b04dcf1 into laktak:master Jul 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants