fix: copy-mode support for edit and recent capture - #136
Merged
Conversation
Owner
|
Thanks for your PR! I did not see any side effects, at least on my setup, so I'll merge it as it is. The fallback is good even though I don't like that it eats all errors, making it impossible to diagnose any issues with it. I guess I'll add a debug switch if it is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two copy-mode issues:
editnow works when the target pane is in copy mode.@extrakto_grab_areaset torecent/window recentnow captures the current copy-mode viewport, not the pane tail.Implementation uses
display-messageformats (pane_in_mode,scroll_position,pane_height) to compute capture bounds.I did not use
capture-pane -Mbecause it is only available in tmux 3.6+, while tmux 3.5a is still widely used. E.g. latest Debian Trixie has it.