Skip to content

Conversation

@lalinsky
Copy link
Owner

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Switches JetStream tests from hard-coded names to runtime-generated unique names via new utilities in tests/utils.zig; updates stream and consumer tests accordingly. Adjusts tests/all_tests.zig to import an external test module and removes a per-test cleanup block. Keeps existing beforeAll/afterAll setup.

Changes

Cohort / File(s) Summary of edits
Test harness orchestration
tests/all_tests.zig
Removed in-file tests:beforeEach cleanup of streams; added import of jetstream_large_list_test.zig; retained beforeAll/afterAll docker-compose lifecycle.
JetStream stream tests parameterization
tests/jetstream_stream_test.zig
Replaced hard-coded stream names/subjects with allocator-backed generated values via utils.generateUniqueStreamName and utils.generateSubjectFromStreamName; updated assertions and API calls; added frees via testing.allocator.
JetStream consumer tests parameterization
tests/jetstream_test.zig
Refactored to generate stream_name, consumer_name, and derived subject; updated all consumer-related tests and assertions; added memory management for allocated strings.
Test utilities for unique names
tests/utils.zig
Added atomic counter and public helpers: generateUniqueName, generateUniqueStreamName, generateUniqueConsumerName, generateSubjectFromStreamName; existing waitForHealthyServices unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c176060 and cec17b6.

📒 Files selected for processing (4)
  • tests/all_tests.zig (1 hunks)
  • tests/jetstream_stream_test.zig (11 hunks)
  • tests/jetstream_test.zig (7 hunks)
  • tests/utils.zig (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tests-with-unique-names

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lalinsky lalinsky closed this Aug 29, 2025
@lalinsky lalinsky deleted the tests-with-unique-names branch September 13, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant