Skip to content

fix: solve the packaging to include the styles folder#5

Merged
MrtinoRG merged 1 commit into
mainfrom
solve_packaging
Aug 8, 2025
Merged

fix: solve the packaging to include the styles folder#5
MrtinoRG merged 1 commit into
mainfrom
solve_packaging

Conversation

@MrtinoRG
Copy link
Copy Markdown
Collaborator

@MrtinoRG MrtinoRG commented Aug 4, 2025

Summary by Sourcery

Include the styles directory in the package distribution by configuring package-data in pyproject.toml and adding a MANIFEST.in file

Build:

  • Add [tool.setuptools.package-data] entry in pyproject.toml to include styles/*.mplstyle files
  • Create MANIFEST.in to ensure the styles folder is included in source distributions

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 4, 2025

Reviewer's Guide

This PR enhances the project’s packaging configuration by adding a setuptools package-data section and a MANIFEST.in file so that the styles folder (MPL style files) is included in both source and binary distributions.

Flow diagram for packaging process with styles folder inclusion

flowchart TD
    Start([Start packaging])
    CheckPyproject[Check pyproject.toml for package-data]
    CheckManifest[Check MANIFEST.in for styles inclusion]
    IncludeStyles[Include styles/*.mplstyle in package]
    BuildDist[Build source and binary distributions]
    End([Distributions include styles folder])

    Start --> CheckPyproject --> CheckManifest --> IncludeStyles --> BuildDist --> End
Loading

File-Level Changes

Change Details Files
Configure setuptools to include MPL style files as package data
  • Added a [tool.setuptools.package-data] section
  • Specified lama_aesthetics = ["styles/*.mplstyle"]
pyproject.toml
Introduce a MANIFEST.in to ensure styles folder is packaged in sdist
  • Created a new MANIFEST.in file
  • Configured recursive inclusion of the styles directory
MANIFEST.in

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@MrtinoRG MrtinoRG requested a review from kjappelbaum August 4, 2025 06:45
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MrtinoRG - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kjappelbaum
Copy link
Copy Markdown

actions fail, but this seems to not be due to your PR

@MrtinoRG MrtinoRG merged commit 8e19053 into main Aug 8, 2025
0 of 4 checks passed
@MrtinoRG MrtinoRG deleted the solve_packaging branch August 8, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants