ci(l1): add cleanup step to daily snapsync workflow #6131
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -86,6 +86,12 @@ jobs: | |||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| echo "timestamp=$EPOCHSECONDS" >> "$GITHUB_OUTPUT" | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| - name: Cleanup stale Docker and Kurtosis resources | ||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| kurtosis clean -a || true | ||||||||||||||||||||||||||
| docker network prune -f | ||||||||||||||||||||||||||
| docker image prune -f | ||||||||||||||||||||||||||
|
Comment on lines
+89
to
+93
There was a problem hiding this comment. Consider adding error logging for the cleanup step to help diagnose if cleanup fails
Suggested change
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/workflows/daily_snapsync.yaml
Line: 89:93
Comment:
Consider adding error logging for the cleanup step to help diagnose if cleanup fails
```suggestion
- name: Cleanup stale Docker and Kurtosis resources
run: |
echo "Starting cleanup of stale resources..."
kurtosis clean -a || echo "Warning: kurtosis clean failed"
docker network prune -f || echo "Error: docker network prune failed"
docker image prune -f || echo "Error: docker image prune failed"
echo "Cleanup completed"
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+89
to
+93
There was a problem hiding this comment. The cleanup logic is duplicated identically in both the sync-lighthouse and sync-prysm jobs. Consider extracting this into a reusable composite action (similar to the existing actions in .github/actions/) to improve maintainability and ensure consistency. This would make it easier to update the cleanup logic in the future if additional cleanup steps are needed. There was a problem hiding this comment. Consider adding docker container prune -f to clean up stopped containers as well. While docker image prune only removes dangling images and docker network prune removes unused networks, stopped containers can also consume resources and may contribute to resource exhaustion issues. This is optional but could provide more thorough cleanup. |
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| - name: Run Snapsync Test | ||||||||||||||||||||||||||
| uses: ./.github/actions/snapsync-run | ||||||||||||||||||||||||||
| id: snapsync | ||||||||||||||||||||||||||
|
|
@@ -127,6 +133,12 @@ jobs: | |||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| echo "timestamp=$EPOCHSECONDS" >> "$GITHUB_OUTPUT" | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| - name: Cleanup stale Docker and Kurtosis resources | ||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| kurtosis clean -a || true | ||||||||||||||||||||||||||
| docker network prune -f | ||||||||||||||||||||||||||
| docker image prune -f | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| - name: Run Snapsync Test | ||||||||||||||||||||||||||
| uses: ./.github/actions/snapsync-run | ||||||||||||||||||||||||||
| id: snapsync | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding
docker volume prune -fto also clean up unused volumes, which can accumulate from Kurtosis enclavesNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI