fix(l1): resolve repl against the root workspace - #7134
Open
questfever wants to merge 1 commit into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
github-actions
Bot
added
the
external-contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tooling/replis declared as a member of the root workspace, but Cargo discoverstooling/Cargo.tomlfirst when the repl manifest is used directly.Because the tooling workspace does not include
repl, commands such as:cargo metadata --manifest-path tooling/repl/Cargo.toml --no-depsfail with:
current package believes it's in a workspace when it's notDescription
Explicitly set the package workspace to the repository root with:
workspace = "../.."This makes manifest-relative Cargo invocations resolve
tooling/replagainst the workspace that already declares it as a member.tooling/runneris not included in this change because it is not present undertooling/on the current main branch.Checklist
STORE_SCHEMA_VERSION(crates/storage/lib.rs) if the PR includes breaking changes to theStorerequiring a re-sync.Closes #7107