fix: declare the OpenSSL dependency needed on Linux - #20
Merged
Conversation
The Linux source build has been failing in `openssl-sys`' build script:
The system library `openssl` required by crate `openssl-sys` was not
found. The file `openssl.pc` needs to be installed and the
PKG_CONFIG_PATH environment variable must contain its parent directory.
`ethrex` depends on `reqwest` with its default TLS backend, `native-tls`.
On Linux that is OpenSSL, so `openssl-sys` gets built and looks for the
library through `pkg-config`. Neither `pkg-config` nor `openssl@3` was a
declared dependency, so Homebrew's superenv left `PKG_CONFIG_PATH` unset
and the keg-only OpenSSL was invisible even though it was already in the
dependency tree as a transitive dependency.
macOS is unaffected: there `native-tls` uses Security.framework and
`openssl-sys` is never built, which is why only the Linux job broke.
Keeping the dependencies inside `on_linux` leaves the macOS dependency
tree, and its bottle, untouched.
ilitteri
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare
openssl@3andpkgconfas Linux-only dependencies ofethrex.Why
The Linux source build fails in
openssl-sys' build script (run 32897389813, ubuntu-24.04):ethrexdepends onreqwestwith its default TLS backend,native-tls:On Linux
native-tlsis OpenSSL, soopenssl-sysgets built and probes for the library withpkg-config. Homebrew's superenv buildsPKG_CONFIG_PATHfrom the formula's declared dependencies, so neither the keg-onlyopenssl@3nor thepkg-configbinary was reachable, even though both were already in the tree as transitive dependencies of the build tools.On macOS
native-tlsuses Security.framework andopenssl-sysis never built, which is why only the Linux job broke. Scoping the dependencies toon_linuxleaves the macOS dependency tree, and the existingarm64_sonomabottle, untouched.Notes
brew styleandbrew audit --skip-stylepass locally;brew depson macOS is unchanged.reqwesttorustls-tlsand drop the OpenSSL dependency entirely. Worth doing on its own merits, but it does not help the released 25.0.0 tarball this formula builds.