Skip to content

ci: stop a formula that fails to build from reporting a green job #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilitteri merged 1 commit into from
Aug 26, 2026
Merged

ci: stop a formula that fails to build from reporting a green job #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,23 @@ jobs:
- run: brew test-bot --only-formulae
if: github.event_name == 'pull_request'

# `brew test-bot` downgrades a failing step to a warning when the formula
# has no bottle for the current platform, and still exits 0. Every version
# bump hits that case, so a formula that does not build at all reports a
# green job. Turn those ignored failures back into a red job.
- name: Fail on ignored test-bot failures
if: ${{ !cancelled() && github.event_name == 'pull_request' }}
run: |
if [ ! -f steps_output.txt ]; then
echo "::error::brew test-bot wrote no steps_output.txt, cannot tell whether it ignored a failure"
exit 1
fi
cat steps_output.txt
if grep -q 'failed step' steps_output.txt; then
echo "::error::brew test-bot ignored a failing step, see the summary above"
exit 1
fi

- name: Upload bottles as artifact
if: always() && github.event_name == 'pull_request'
uses: actions/upload-artifact@v4
Expand Down
Loading