Test/swap - #193
Open
rcatalan98 wants to merge 41 commits into
Open
Conversation
rcatalan98
marked this pull request as ready for review
December 1, 2023 18:49
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: dubzn <santiagodgalvan@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: rcatalan98 <robertitocatalan@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: dubzn <santiagodgalvan@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: Santiago Galván (Dub) <santiagodgalvan@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: Uri <umihura@itba.edu.ar>
Co-authored-by: Santiago Galván (Dub) <santiagodgalvan@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: dpinones <pinonesdamian@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: dubzn <santiagodgalvan@gmail.com> Co-authored-by: dpinones <pinonesdamian@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: dpinones <pinonesdamian@gmail.com> Co-authored-by: dubzn <santiagodgalvan@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: Santiago Galván (Dub) <santiagodgalvan@gmail.com> Co-authored-by: dpinones <pinonesdamian@gmail.com>
Co-authored-by: dpinones <pinonesdamian@gmail.com> Co-authored-by: Damián Piñones <30808181+dpinones@users.noreply.github.com> Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: dubzn <santiagodgalvan@gmail.com> Co-authored-by: dpinones <pinonesdamian@gmail.com>
Co-authored-by: Uriel Mihura <uriel.mihura@gmail.com> Co-authored-by: dubzn <santiagodgalvan@gmail.com> Co-authored-by: dpinones <pinonesdamian@gmail.com>
uri-99
previously approved these changes
Jan 2, 2024
This reverts commit 2c2c06e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves issue #149
Swap tests were dividied into Pool Cases, and also Swap Cases. Then, each Swap Case is executed in each Pool Case.
This is why this Issue is divided into smaller issues, one issue per Pool Case.
This PR will be done and merged into main branch after all pool cases are done and working correctly.