Skip to content

Php8.4 support#100

Merged
samsonasik merged 11 commits intolaminas:3.15.xfrom
cod43156:php8.4-support
Feb 25, 2025
Merged

Php8.4 support#100
samsonasik merged 11 commits intolaminas:3.15.xfrom
cod43156:php8.4-support

Conversation

@cod43156
Copy link
Contributor

@cod43156 cod43156 commented Feb 6, 2025 •
edited by samsonasik
Loading

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

PHP 8.4 Support

closes #97
closes #98

@cod43156 cod43156 force-pushed the php8.4-support branch 2 times, most recently from 9ff3c80 to 8f75e6e Compare February 13, 2025 12:13
froschdesign
froschdesign reviewed Feb 13, 2025
View reviewed changes
composer.json Outdated
},
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.2.0 || ~8.3.0 || ~8.4.0",
Copy link
Member

@froschdesign froschdesign Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is version 8.1 removed?

Copy link
Contributor Author

@cod43156 cod43156 Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@froschdesign Ocramius recommended removing support for PHP 8.1 in this comment: #98 (comment)

Copy link
Member

@froschdesign froschdesign Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be removed but it should be kept for now:

Ultimately, the support for PHP version 8.1 will be kept in Laminas packages for now, because PHP 8.1 will still receive security fixes until January 1st 2026. This has the added benefit of minimizing the impact on users of Laminas packages. The only limitation right now is for PHPUnit which stays at version 10.

https://getlaminas.org/blog/2025-02-03-summary-of-the-meeting-in-february-2025.html

Copy link
Contributor Author

@cod43156 cod43156 Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update PHPUnit from version 9 to 10 in this repository?

@froschdesign
Copy link
Member

froschdesign commented Feb 14, 2025 •
edited
Loading

@cod43156
This can help:

"conflict": {
    "amphp/amp": "<2.6.4"
},

Compare with: https://github.com/laminas/laminas-diactoros/blob/746db20f063a7cf11c6551c0a6d8aee7ddc7d236/composer.json#L76-L78

samsonasik
samsonasik reviewed Feb 17, 2025
View reviewed changes
tux-rampage and others added 11 commits February 18, 2025 12:00
@tux-rampage @cod43156
Add support for PHP 8.4
2aff4c6 
Signed-off-by: tux-rampage <tuxrampage@gmail.com>
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@tux-rampage @cod43156
Add laminas ci config
b22ae27 
Signed-off-by: tux-rampage <tuxrampage@gmail.com>
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Doc Lint Issue Fixes
52df5e8 
Signed-off-by: Raj Mohan <cod43156@adobe.com>
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
PHPUnit Test Fixes
0c62f9b 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Update composer.lock
5f0cc24 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Update PHP Unit
b94ccbd 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Update Dependencies
0112af0 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Update mikey179/vfsstream
f87b369 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Fix Psalm and PHPCS Issues
ddb0869 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Revert PHP8.1 Support
78fb71e 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@cod43156
Correct Assertion Message for ConfigFactoryTest
9a361fc 
Signed-off-by: Raj Mohan R <cod43156@adobe.com>
@glo71317
Copy link
Contributor

glo71317 commented Feb 24, 2025

Hi @froschdesign Are we planning to move forward with this PR soon, or is there more information needed from PR provider?

@samsonasik samsonasik added this to the 3.15.0 milestone Feb 24, 2025
@samsonasik samsonasik merged commit de00225 into laminas:3.15.x Feb 25, 2025
17 checks passed
@samsonasik
Copy link
Member

samsonasik commented Feb 25, 2025

Thank you @glo71317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

@froschdesign froschdesign Awaiting requested review from froschdesign

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

3.15.0

Development

Successfully merging this pull request may close these issues.

php 8.4 support

5 participants

@cod43156 @froschdesign @glo71317 @samsonasik @tux-rampage