Refactor configuration to immutable types#103
Open
tux-rampage wants to merge 3 commits intolaminas:3.17.xfrom
Open
Refactor configuration to immutable types#103tux-rampage wants to merge 3 commits intolaminas:3.17.xfrom
tux-rampage wants to merge 3 commits intolaminas:3.17.xfrom
Conversation
tux-rampage
added
RFC
QA
Signed-off-by: tux-rampage <tuxrampage@gmail.com>
Signed-off-by: tux-rampage <tuxrampage@gmail.com>
tux-rampage
force-pushed
the
feature/typed-config
branch
from
39fb3c1 to
a60f5c3
Compare
Ocramius
reviewed
Feb 5, 2026
src/Config/InjectionConfig.php
Outdated
| * @see \Laminas\Di\Resolver\ValueInjection A container to force injection of a value | ||
| * @see \Laminas\Di\Resolver\TypeInjection A container to force looking up a specific type instance for injection | ||
| * | ||
| * @readonly |
Member
There was a problem hiding this comment.
FWIW, this can now be marked readonly via the language itself
Member
Author
There was a problem hiding this comment.
Since support for php 8.1 is now gone, indeed.
Signed-off-by: tux-rampage <tuxrampage@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for #95, this PR will refactor the configuration to immutable types to follow a parse over validate strategy and to declare the configuration structure type safe in code.
Since the configuration should be considered immutable, the
setParameters()method needs to be deprecated.A possible BC-Break is that it will throw an Exception when called. However, user's can opt-in into the mutable config behavior by setting a config option. The message of the thrown exception will also hint to it.
The config method
getConfiguredTypeNames()is also deprecated in favor of extracting the code generation to a separate package. It is not needed at runtime.