Bump support for laminas-servicemanager to 4.4.0#259
Open
settermjd wants to merge 1 commit intolaminas:3.3.xfrom
Open
Bump support for laminas-servicemanager to 4.4.0#259settermjd wants to merge 1 commit intolaminas:3.3.xfrom
settermjd wants to merge 1 commit intolaminas:3.3.xfrom
Conversation
While not strictly necessary, I've created this change to support the latest version of laminas-servicemanager that contains the removes duplicate delegators fix. See laminas/laminas-servicemanager#251. By including this change, I can then update laminas-inputfilter to support the same version of laminas-servicemanager as well. Signed-off-by: Matthew Setter <matthew@matthewsetter.com>
settermjd
force-pushed
the
support-laminas-servicemanager-4.4.x
branch
from
aff03b8 to
a86a147
Compare
Member
|
@settermjd It'll be a while before input-filter is released with SMv4 support as it's a pretty big change. It will likely support To rephrase, I don't see the point - it's not the role of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While not strictly necessary for laminas-filter, I've created this change to support the latest version of laminas-servicemanager that contains the removes duplicate delegators fix. By including this change, I can then update laminas-inputfilter to support the same version of laminas-servicemanager as well, as it depends on laminas-filter.
As some background, the reason for the version bump is that a project I'm working on depends on laminas-servicemanager and laminas-inputfilter, but needs to have the above fix, as without it when loaded into a Mezzio project, its ConfigProvider classes, which loads a set of custom routes, will cause a duplicate route exception if the existing project's ConfigProvider class also loads routes into the applications routing table.